-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Discover Timeline Integration URL Sync + Fixes #163305
Merged
logeekal
merged 39 commits into
elastic:main
from
logeekal:fix/discover_tab_url_sync_fixes
Aug 29, 2023
Merged
Changes from 36 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
e88eb3c
fix: chart drag time select
logeekal 5e2322a
fix: remove saperate instance of filter manager
logeekal e6f85fe
incremental + cypress tests
logeekal 7c8ab33
incremental commit 2 - state management working
logeekal 9a49dd0
fix: override lens trigger
logeekal 7934b9b
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine eb4bd14
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 4b5ca55
cleanup: remove unncessary changes
logeekal c89c7c9
Merge main ➡️ current branch
logeekal bf1e79b
fix: tests
logeekal d96de65
fix: state sync
logeekal 76ab819
Merge branch 'main' into fix/discover_tab_url_sync_fixes
logeekal 9a35ea0
fix: more tests + lens import remove
logeekal 19798f2
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine 94c2418
discoverInTimeline feature flag should be false by default
logeekal 7049c10
fix: stop discover sync
logeekal 842d5ea
refactor: cypress feature flag
logeekal 95d4ee2
fix: more fixes + tests
logeekal 75d8e04
refactor: add memoize
logeekal 4a0ba9f
fix: types
logeekal 721d26c
refactor: skip tests
logeekal db07cc0
Merge main ➡️ current branch
logeekal fa18ca7
chore: remove unncessary changes
logeekal 7f0e552
fix: review feedback
logeekal 9142901
Merge main ➡️ current branch
logeekal 130f5a1
Merge branch 'main' into fix/discover_tab_url_sync_fixes
logeekal 2fce8f0
test: more unit tests
logeekal 7a8000b
Merge branch 'main' into fix/discover_tab_url_sync_fixes
logeekal ff085d5
fix: types
logeekal 8b66bf1
Merge branch 'main' into fix/discover_tab_url_sync_fixes
logeekal 08b01bb
fix: add tests in serverless
logeekal 69ebb48
refactor: syncstate -> set + replace URL state
logeekal 8300e46
test: unit test for embedded mode
logeekal dd23497
misc feedback
logeekal f59b1ec
fix: remove unncessary code
logeekal 828f5ab
Merge branch 'main' into fix/discover_tab_url_sync_fixes
logeekal 456be46
Merge branch 'main' into fix/discover_tab_url_sync_fixes
logeekal fc171ed
Merge branch 'main' into fix/discover_tab_url_sync_fixes
logeekal 76fd62f
fix: refactor based on main changes
logeekal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/plugins/discover/public/customizations/customization_types/histogram_customization.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import type { UnifiedHistogramContainerProps } from '@kbn/unified-histogram-plugin/public'; | ||
|
||
interface UnifiedHistogramCustomizationId { | ||
id: 'unified_histogram'; | ||
} | ||
|
||
export type UnifiedHistogramCustomization = UnifiedHistogramCustomizationId & | ||
Pick< | ||
UnifiedHistogramContainerProps, | ||
'onFilter' | 'onBrushEnd' | 'withDefaultActions' | 'disabledActions' | ||
>; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense, embedded | standalone. What do you think about a 2nd prop, an appId to redirect if mode === 'embedded'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I understand this suggestion. Are you referring to redirecting requests to Discover to another app based on an
appId
prop?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, for determining path, if discover is being used at a different path in both security and observability serverless modes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guess that might not work with locators and the like, as those run during discover setup. Probably makes more sense to do something at a config level then? maybe a discover.location setting that we set only in serverless.obit.yml/serverless.security.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to add parameter in
discover.locator
called, appId where locator will develop the URL based on the appID given?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observability currently doesn't use Discover at a different path or embedded in another app. They're using the
profile
functionality in the customization framework to customize Discover as a top level app, so their use case around URLs and paths is a bit different (and already supported).Yeah I agree, I don't think this would be possible through the container component.
I'd like for the Security redirecting logic not to live in the Discover codebase or be owned/maintained by the Data Discovery team, so I'd prefer not to take this approach. I'd be open to a YAML config that disables access to Discover as a top level app or similar, but owning and maintaining the redirect logic should be the responsibility of the Security Solution.
I'd also prefer to avoid this since it would introduce knowledge of the Security redirect logic directly into the Discover codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In light of today's Discover Working Stream, scratch this -- looks like Observability will be embedding the Discover container now (I just learned of this now). With that said, they seem to be planning to include the main Discover app in their project, so their use case around URLs and redirecting is still different since existing links will presumably continue to take users to the main Discover app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davismcphee thanks for the info. What do you think if client can pass callback to locator to provide a client specific location. This will prevent any other plugin's logic in Discover?
cc: @kqualters-elastic