-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Risk engine initialisation, update from legacy risk engine workflow and status change #162400
Conversation
b473ff4
to
f9c2c02
Compare
1ecd83c
to
805d243
Compare
/** | ||
* Fetches risks engine status | ||
*/ | ||
export const fetchRiskEngineStatus = async ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this with your previous PR, but: can you explain the logic behind the folder naming here? Explore team originally introduced risk_score
folders, and I tried to generalize that to risk_engine
stuff, but now it seems like we're broadening that to entity_analytics
, here? Not a judgement, I'm just trying to understand the intention and keep things consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My original idea was to introduce the new public folder, for all things related to EA (watchlist, etc)
If you think we should rename/move things please let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds reasonable; thanks for the explanation. Perhaps as we move the client code to pull from the new risk score data, we can move those files/folders under entity_analytics
?
} | ||
|
||
export interface InitRiskEngineResult { | ||
leggacyRiskEngineDisabled: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leggacyRiskEngineDisabled: boolean; | |
legacyRiskEngineDisabled: boolean; |
...gins/security_solution/public/entity_analytics/api/hooks/use_disable_risk_engine_mutation.ts
Show resolved
Hide resolved
...k/plugins/security_solution/public/entity_analytics/components/risk_score_enable_section.tsx
Show resolved
Hide resolved
...k/plugins/security_solution/public/entity_analytics/components/risk_score_enable_section.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/risk_engine/risk_engine_data_client.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/risk_engine/schema/risk_score_apis.yml
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/risk_engine/schema/risk_score_apis.yml
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/risk_engine/routes/risk_engine_init_route.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/lib/risk_engine/schema/risk_score_apis.yml
Outdated
Show resolved
Hide resolved
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appex QA changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 👍
I left just one question as a Defend Workflows review :)
Trial licenses are included in `.isPlatinumPlus`, we don't need to check that ourselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defend Workflows lgtm 👍
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
@elasticmachine merge upstream |
ignoring request to update branch, pull request is closed |
Risk engine initialisation, update from legacy risk engine workflow and status change
Screen.Recording.2023-08-01.at.15.00.35.mov
Green areas it is what was implemented
This pr has:
It required experiment enabled - riskScoringRoutesEnabled
New API
/engine/status
GET
Get the status of the Risk Engine
Description:
Returns the status of both the legacy transform-based risk engine, as well as the new risk engine
Responses
/engine/init
POST
Initialize the Risk Engine
Description:
Initializes the Risk Engine by creating the necessary indices and mappings, removing old transforms, creating saved object configuration
Responses
/engine/enable
POST
Enable the Risk Engine
Description:
Change saved object configuration and in the future here we will start task
/engine/disable
POST
Disable the Risk Engine
Change saved object configuration and in the future here we will stop task