[build/docker] Upgrade Ubuntu base image to 22.04 #162282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbudz
added
Team:Operations
jbudz
added
ci:cloud-redeploy
|
buildkite test this |
jbudz
added
ci:build-serverless-image
and removed
ci:cloud-redeploy
jbudz
added
release_note:enhancement
and removed
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
commented
Oct 18, 2023
| @@ -189,7 +189,7 @@ ENTRYPOINT ["/bin/tini", "--"] | |||
| CMD ["/app/kibana.sh"] | |||
| # Generate a stub command that will be overwritten at runtime | |||
| RUN mkdir /app && \ | |||
| echo -e '#!/bin/bash\nexec /usr/local/bin/kibana-docker' > /app/kibana.sh && \ | |||
| /usr/bin/echo -e '#!/bin/bash\nexec /usr/local/bin/kibana-docker' > /app/kibana.sh && \ | |||
There was a problem hiding this comment.
This is for local testing and can be ignored, it's meant to be overwritten. RUN uses sh, which has a builtin echo that doesn't support the -e flag.
Ikuni17
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Thanks for upgrading Jon. The deployment images look fine. Think we need a doc update here:
kibana/docs/setup/docker.asciidoc
Line 13 in 8fd827f
Also, do you think this could be considered a breaking change for downstream users? Do users use the Kibana image as a base image?
jbudz
added
ci:cloud-redeploy
Ikuni17
approved these changes
Oct 23, 2023
💚 Build Succeeded
Metrics [docs]Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
jbudz
added
backport:prev-minor
|
I'm going to manually open a 7.17 backport, splitting off the docs changes to a separate pull request that's merged after the next 7.17 release. Will link in a moment. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 23, 2023
Release note: The default container's base image has been upgraded from Ubuntu 20.04 to 22.04 (cherry picked from commit 9d139f6)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Oct 23, 2023
Release note: The default container's base image has been upgraded from Ubuntu 20.04 to 22.04
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2023
…169580) # Backport This will backport the following commits from `main` to `8.11`: - [[build/docker] Upgrade Ubuntu base image to 22.04 (#162282)](#162282) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-23T19:49:06Z","message":"[build/docker] Upgrade Ubuntu base image to 22.04 (#162282)\n\nRelease note:\r\nThe default container's base image has been upgraded from Ubuntu 20.04\r\nto 22.04","sha":"9d139f6192647a91010e95c84d651644158abc69","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:Operations","backport:prev-minor","ci:cloud-redeploy","ci:build-serverless-image","v8.12.0"],"number":162282,"url":"https://github.com/elastic/kibana/pull/162282","mergeCommit":{"message":"[build/docker] Upgrade Ubuntu base image to 22.04 (#162282)\n\nRelease note:\r\nThe default container's base image has been upgraded from Ubuntu 20.04\r\nto 22.04","sha":"9d139f6192647a91010e95c84d651644158abc69"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/162282","number":162282,"mergeCommit":{"message":"[build/docker] Upgrade Ubuntu base image to 22.04 (#162282)\n\nRelease note:\r\nThe default container's base image has been upgraded from Ubuntu 20.04\r\nto 22.04","sha":"9d139f6192647a91010e95c84d651644158abc69"}}]}] BACKPORT--> Co-authored-by: Jon <[email protected]>
jbudz
added a commit
that referenced
this pull request
Oct 24, 2023
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Nov 2, 2023
…stic#162282) (elastic#169580)" This reverts commit a382569.
jbudz
added a commit
to jbudz/kibana
that referenced
this pull request
Nov 2, 2023
…stic#162282) (elastic#169581)" This reverts commit c8260c3.
|
There's issues starting node on hosts running older versions of Ubuntu. |
jbudz
added a commit
that referenced
this pull request
Nov 2, 2023
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Nov 6, 2023
…2282)" (elastic#170430) This reverts commit 9d139f6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note:
reverted
The default container's base image has been upgraded from Ubuntu 20.04 to 22.04