Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/142865/path.data config unused #158426

Merged
merged 54 commits into from
Nov 29, 2023
Merged

fix/142865/path.data config unused #158426

merged 54 commits into from
Nov 29, 2023

Conversation

Ikuni17
Copy link
Contributor

@Ikuni17 Ikuni17 commented May 24, 2023

Readding #157659 after being reverted in #158325

@Ikuni17 Ikuni17 self-assigned this May 24, 2023
@Ikuni17 Ikuni17 requested a review from a team as a code owner May 24, 2023 22:09
@github-actions
Copy link
Contributor

Documentation preview:

@Ikuni17 Ikuni17 added backport release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team labels May 24, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

jbudz
jbudz reviewed May 25, 2023
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were we able to reproduce the issue from before / have steps that can be shared? The test failure seemed to imply kibana.yml was not loaded

@Ikuni17
Copy link
Contributor Author

Ikuni17 commented May 25, 2023

@jbudz I don't have access to elastic/ess-k8s-e2e-tests repo. I want to run those before merging this again. Is it possible to run the pipeline against this branch or run them locally?

@Ikuni17
Copy link
Contributor Author

Ikuni17 commented May 26, 2023

@afharo Can you advise on running this against elastic/ess-k8s-e2e-tests? Would like to make sure we don't block the image promotion again

@Ikuni17 Ikuni17 requested a review from afharo May 26, 2023 15:29
@afharo
Copy link
Member

afharo commented May 27, 2023

@Ikuni17, AFAIK, @elastic/kibana-operations knows better about how to trigger those builds 😇

@watson watson removed the backport label Jul 28, 2023
@watson
Copy link
Contributor

watson commented Jul 28, 2023 •
edited
Loading

@Ikuni17 I removed the backport label from this PR. I assume it was added by a mistake. The backport label is for PRs that are backports of other PRs. If you want skip backporting a specific PR, you should use backport:skip instead. Maybe that is what you intended?

@Ikuni17
Copy link
Contributor Author

Ikuni17 commented Jul 28, 2023

@Ikuni17 I removed the backport label from this PR. I assume it was added by a mistake. The backport label is for PRs that are backports of other PRs. If you want skip backporting a specific PR, you should use backport:skip instead. Maybe that is what you intended?

@watson Added by mistake, thanks for picking that up. The 7.17 backport is manual for this PR (#158116) due to config deprecation in 8.x and how this settings works.

@Ikuni17 Ikuni17 added ci:project-deploy-security Create a Security Serverless Project and removed ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-deploy-observability Create an Observability project labels Nov 28, 2023
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 28, 2023 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/utils 14 15 +1

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5661 +5661
total size - 5.9MB +5.9MB
Unknown metric groups

API count

id before after diff
@kbn/utils 24 25 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Ikuni17

@Ikuni17 Ikuni17 merged commit 86d2f58 into elastic:main Nov 29, 2023
@Ikuni17 Ikuni17 deleted the fix/142865/path.data-config-unused branch November 29, 2023 00:16
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 29, 2023
@Ikuni17 Ikuni17 mentioned this pull request Nov 29, 2023
Merged
Ikuni17 added a commit to Ikuni17/kibana that referenced this pull request Nov 29, 2023
@Ikuni17
fix/142865/path.data config unused (elastic#158426)
3b4b341 
(cherry picked from commit 86d2f58)
Ikuni17 added a commit to Ikuni17/kibana that referenced this pull request Nov 29, 2023
@Ikuni17
fix/142865/path.data config unused (elastic#158426)
68d1cde 
(cherry picked from commit 86d2f58)

# Conflicts:
#	packages/kbn-utils/src/path/index.test.ts
#	packages/kbn-utils/src/path/index.ts
#	packages/kbn-utils/tsconfig.json
@Ikuni17 Ikuni17 mentioned this pull request Nov 29, 2023
Closed
@Ikuni17
Copy link
Contributor Author

Ikuni17 commented Nov 29, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.11
✅ 7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@Ikuni17
Copy link
Contributor Author

Ikuni17 commented Nov 29, 2023 •
edited
Loading

The successful E2E test run and artifact promotion for this PR is available here

Ikuni17 added a commit that referenced this pull request Nov 29, 2023
@Ikuni17
[8.11] fix/142865/path.data config unused (#158426) (#172200)
c504960 
# Backport

This will backport the following commits from `main` to `8.11`:
- [fix/142865/path.data config unused
(#158426)](#158426)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Brad
White","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-29T00:16:47Z","message":"fix/142865/path.data
config unused
(#158426)","sha":"86d2f58c09b3bfedd12576f9fc5fe68649028f9c","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:skip","ci:cloud-deploy","ci:project-deploy-security","v8.12.0"],"number":158426,"url":"https://github.com/elastic/kibana/pull/158426","mergeCommit":{"message":"fix/142865/path.data
config unused
(#158426)","sha":"86d2f58c09b3bfedd12576f9fc5fe68649028f9c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/158426","number":158426,"mergeCommit":{"message":"fix/142865/path.data
config unused
(#158426)","sha":"86d2f58c09b3bfedd12576f9fc5fe68649028f9c"}}]}]
BACKPORT-->
@delanni delanni mentioned this pull request Dec 8, 2023
Closed
jbudz added a commit to jbudz/kibana that referenced this pull request Dec 8, 2023
@jbudz
Revert "fix/142865/path.data config unused (elastic#158426)"
b5f8b21 
This reverts commit 86d2f58.
@delanni
Copy link
Contributor

delanni commented Dec 8, 2023

We're reverting this (once again) in #172943 - in the 8.10.2 release, we saw that the ECK use case is using the keystore without having the config in its final place, which caused a file read error trying to parse the configs to acquire these data paths.

We've decided to roll back and evaluate options to start respecting the path.data values, but with preference to already existing keystores (should there be any created on the default paths). With this, the feature could be added with proper backward compatibility.

jbudz added a commit to jbudz/kibana that referenced this pull request Dec 8, 2023
@jbudz
Revert "fix/142865/path.data config unused (elastic#158426)"
6deaee3 
This reverts commit 86d2f58.
jbudz added a commit that referenced this pull request Dec 8, 2023
@jbudz
Revert "fix/142865/path.data config unused (#158426)" (#172951)
ee194d3 
This reverts commit 86d2f58.

Forward port of #172943 targeting
8.13 and 8.12. See the linked pr for 8.11.3 release notes.

Closes #172919
jbudz added a commit that referenced this pull request Dec 8, 2023
@jbudz
[8.11] Revert "fix/142865/path.data config unused (#158426)" (#172943)
cc11667 
This reverts commit 86d2f58.

#172919

Release note:
Fixes an issue where running `kibana-keystore` commands required
`kibana.yml` to exist.
kibanamachine pushed a commit that referenced this pull request Dec 8, 2023
@jbudz
Revert "fix/142865/path.data config unused (#158426)" (#172951)
34bfd1d 
This reverts commit 86d2f58.

Forward port of #172943 targeting
8.13 and 8.12. See the linked pr for 8.11.3 release notes.

Closes #172919

(cherry picked from commit ee194d3)
kibanamachine added a commit that referenced this pull request Dec 19, 2023
@kibanamachine @jbudz @Ikuni17
[8.12] Revert "fix/142865/path.data config unused (#158426)" (#172951) (
79a0f48 
#172970)

# Backport

This will backport the following commits from `main` to `8.12`:
- [Revert "fix/142865/path.data config unused (#158426)"
(#172951)](#172951)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-12-08T16:22:21Z","message":"Revert
\"fix/142865/path.data config unused (#158426)\" (#172951)\n\nThis
reverts commit 86d2f58.\r\n\r\nForward
port of #172943 targeting\r\n8.13
and 8.12. See the linked pr for 8.11.3 release notes.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/172919","sha":"ee194d32a2e21baf6ae38a2e60e590ac3811b9f1","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","auto-backport","v8.12.0"],"number":172951,"url":"https://github.com/elastic/kibana/pull/172951","mergeCommit":{"message":"Revert
\"fix/142865/path.data config unused (#158426)\" (#172951)\n\nThis
reverts commit 86d2f58.\r\n\r\nForward
port of #172943 targeting\r\n8.13
and 8.12. See the linked pr for 8.11.3 release notes.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/172919","sha":"ee194d32a2e21baf6ae38a2e60e590ac3811b9f1"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jon <[email protected]>
Co-authored-by: Brad White <[email protected]>
@Ikuni17 Ikuni17 mentioned this pull request Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbudz jbudz jbudz left review comments

@afharo afharo afharo approved these changes

Assignees

@Ikuni17 Ikuni17

Labels
backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment ci:project-deploy-security Create a Security Serverless Project release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.11.2 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Ikuni17 @elasticmachine @afharo @watson @mistic @kibana-ci @delanni @jbudz @kibanamachine