-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Edits Kibana alerting settings #155318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview: |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
lcawl
added
Team:Docs
docs
v8.8.0
v8.7.2
release_note:skip
Skip the PR/issue when compiling release notes
labels
Apr 19, 2023
Pinging @elastic/kibana-docs (Team:Docs) |
szabosteve
approved these changes
Apr 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 27, 2023
(cherry picked from commit 7efe3d5)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 27, 2023
(cherry picked from commit 7efe3d5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
that referenced
this pull request
Apr 27, 2023
# Backport This will backport the following commits from `main` to `8.8`: - [[DOCS] Edits Kibana alerting settings (#155318)](#155318) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T14:26:19Z","message":"[DOCS] Edits Kibana alerting settings (#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","v8.8.0","v8.7.2","v8.9.0"],"number":155318,"url":"https://github.com/elastic/kibana/pull/155318","mergeCommit":{"message":"[DOCS] Edits Kibana alerting settings (#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155318","number":155318,"mergeCommit":{"message":"[DOCS] Edits Kibana alerting settings (#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e"}}]}] BACKPORT--> Co-authored-by: Lisa Cawley <[email protected]>
lcawl
added a commit
that referenced
this pull request
Apr 27, 2023
# Backport This will backport the following commits from `main` to `8.7`: - [[DOCS] Edits Kibana alerting settings (#155318)](#155318) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T14:26:19Z","message":"[DOCS] Edits Kibana alerting settings (#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","v8.8.0","v8.7.2","v8.9.0"],"number":155318,"url":"https://github.com/elastic/kibana/pull/155318","mergeCommit":{"message":"[DOCS] Edits Kibana alerting settings (#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155318","number":155318,"mergeCommit":{"message":"[DOCS] Edits Kibana alerting settings (#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e"}}]}] BACKPORT--> --------- Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #100179
This PR fixes the deprecation details for some Kibana alerting settings, since they didn't indicate the version in which the setting was deprecated.
It also adds some elective improvements, such as the new metadata for migration purposes, fixes the nesting for some of the examples, and removes the unnecessary x-pack role.