Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Edits Kibana alerting settings #155318

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Apr 19, 2023

Summary

Relates to #100179

This PR fixes the deprecation details for some Kibana alerting settings, since they didn't indicate the version in which the setting was deprecated.

It also adds some elective improvements, such as the new metadata for migration purposes, fixes the nesting for some of the examples, and removes the unnecessary x-pack role.

@github-actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl added Team:Docs docs v8.8.0 v8.7.2 release_note:skip Skip the PR/issue when compiling release notes labels Apr 19, 2023
@lcawl lcawl marked this pull request as ready for review April 20, 2023 00:11
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit 7efe3d5 into elastic:main Apr 27, 2023
@lcawl lcawl deleted the setting-deprecations branch April 27, 2023 14:26
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 27, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 27, 2023
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.7
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Apr 27, 2023
# Backport

This will backport the following commits from `main` to `8.8`:
- [[DOCS] Edits Kibana alerting settings
(#155318)](#155318)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T14:26:19Z","message":"[DOCS]
Edits Kibana alerting settings
(#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","v8.8.0","v8.7.2","v8.9.0"],"number":155318,"url":"https://github.com/elastic/kibana/pull/155318","mergeCommit":{"message":"[DOCS]
Edits Kibana alerting settings
(#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155318","number":155318,"mergeCommit":{"message":"[DOCS]
Edits Kibana alerting settings
(#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e"}}]}]
BACKPORT-->

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Apr 27, 2023
# Backport

This will backport the following commits from `main` to `8.7`:
- [[DOCS] Edits Kibana alerting settings
(#155318)](#155318)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-04-27T14:26:19Z","message":"[DOCS]
Edits Kibana alerting settings
(#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","docs","v8.8.0","v8.7.2","v8.9.0"],"number":155318,"url":"https://github.com/elastic/kibana/pull/155318","mergeCommit":{"message":"[DOCS]
Edits Kibana alerting settings
(#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e"}},"sourceBranch":"main","suggestedTargetBranches":["8.8","8.7"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/155318","number":155318,"mergeCommit":{"message":"[DOCS]
Edits Kibana alerting settings
(#155318)","sha":"7efe3d53c6e8dfeec7da7815d2d4c7a2a965c40e"}}]}]
BACKPORT-->

---------

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants