Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infrastructure UI] Fix time range filter in alerts query #153863

Merged
merged 3 commits into from
Apr 3, 2023

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Mar 28, 2023

📓 Summary

Closes #153741

This PR fixes the time range filter by using the kibana.alert.time_range field instead of @timestamp.

🧪 Testing

  • Navigate to Hosts View
  • Create an Inventory Alert that will trigger immediately
  • Refresh the search until some alerts are triggered
  • Play with relative time range (eg. 15 min ago -> 2 min ago) to verify alerts appears correctly

@tonyghiani tonyghiani added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes labels Mar 28, 2023
@tonyghiani tonyghiani requested a review from a team as a code owner March 28, 2023 12:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@tonyghiani tonyghiani enabled auto-merge (squash) April 3, 2023 08:16
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 86.8KB 86.9KB +54.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tonyghiani tonyghiani merged commit 77ce676 into elastic:main Apr 3, 2023
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.7 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.7:
- [Fleet] Disable button in agent details when policy is managed (#154176)

Manual backport

To create the backport manually run:

node scripts/backport --pr 153863

Questions ?

Please refer to the Backport tool documentation

@tonyghiani
Copy link
Contributor Author

Added the backport to 8.7 by mistake, the related feature is introduced in 8.8 so backporting is not necessary.

@tonyghiani tonyghiani deleted the 153741-alerts-by-timerange branch April 3, 2023 09:40
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 15, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 153863 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 153863 locally

@smith smith added the backport:skip This commit does not require backporting label Jul 14, 2024
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infrastructure UI] Update Hosts View Alerts filtering by time-range instead of timestamp
7 participants