Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Fixes certain Related Integrations showing as not installed even when they are #149646

Merged
merged 2 commits into from
Feb 16, 2023
Merged

[Security Solution] Fixes certain Related Integrations showing as not installed even when they are #149646

merged 2 commits into from
Feb 16, 2023

Conversation

spong
Copy link
Member

@spong spong commented Jan 26, 2023 •
edited by kibanamachine
Loading

Summary

Resolves #149644 by adding a fallback for package policies without a policy_template.

@spong spong added release_note:fix Team:Endpoint Response Endpoint Response Team Feature:Detection Rules Security Solution rules and Detection Engine Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.7.0 labels Jan 26, 2023
@spong spong self-assigned this Jan 26, 2023
@spong spong requested a review from a team as a code owner January 26, 2023 23:18
@spong spong requested a review from maximpn January 26, 2023 23:18
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

maximpn
maximpn approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @spong

@spong spong added the v8.6.0 label Feb 16, 2023
@spong spong merged commit ba5634e into elastic:main Feb 16, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 17, 2023
@spong
[Security Solution] Fixes certain Related Integrations showing as `no…
4db6ed4 
…t installed` even when they are (elastic#149646)

## Summary

Resolves elastic#149644 by adding a
fallback for package policies without a policy_template.

(cherry picked from commit ba5634e)
This was referenced Feb 17, 2023
Merged
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 17, 2023
@spong
[Security Solution] Fixes certain Related Integrations showing as `no…
d04670d 
…t installed` even when they are (elastic#149646)

## Summary

Resolves elastic#149644 by adding a
fallback for package policies without a policy_template.

(cherry picked from commit ba5634e)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.6
✅ 8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@spong spong deleted the fix-related-integrations-not-installed branch February 17, 2023 00:08
kibanamachine added a commit that referenced this pull request Feb 17, 2023
@kibanamachine @spong
[8.6] [Security Solution] Fixes certain Related Integrations showing …
76615e0 
…as `not installed` even when they are (#149646) (#151535)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Security Solution] Fixes certain Related Integrations showing as
`not installed` even when they are
(#149646)](#149646)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Garrett
Spong","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-16T23:53:26Z","message":"[Security
Solution] Fixes certain Related Integrations showing as `not installed`
even when they are (#149646)\n\n## Summary\r\n\r\nResolves
#149644 by adding a\r\nfallback
for package policies without a
policy_template.","sha":"ba5634eda6b18ae3d809ba50d21878526c97a8dc","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Endpoint
Response","Feature:Detection Rules","Team:
SecuritySolution","Team:Detection
Rules","backport:prev-minor","v8.6.0","v8.7.0","v8.8.0"],"number":149646,"url":"https://github.com/elastic/kibana/pull/149646","mergeCommit":{"message":"[Security
Solution] Fixes certain Related Integrations showing as `not installed`
even when they are (#149646)\n\n## Summary\r\n\r\nResolves
#149644 by adding a\r\nfallback
for package policies without a
policy_template.","sha":"ba5634eda6b18ae3d809ba50d21878526c97a8dc"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.7"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/149646","number":149646,"mergeCommit":{"message":"[Security
Solution] Fixes certain Related Integrations showing as `not installed`
even when they are (#149646)\n\n## Summary\r\n\r\nResolves
#149644 by adding a\r\nfallback
for package policies without a
policy_template.","sha":"ba5634eda6b18ae3d809ba50d21878526c97a8dc"}}]}]
BACKPORT-->

Co-authored-by: Garrett Spong <[email protected]>
kibanamachine added a commit that referenced this pull request Feb 17, 2023
@kibanamachine @spong
[8.7] [Security Solution] Fixes certain Related Integrations showing …
ca32791 
…as `not installed` even when they are (#149646) (#151536)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Security Solution] Fixes certain Related Integrations showing as
`not installed` even when they are
(#149646)](#149646)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Garrett
Spong","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-02-16T23:53:26Z","message":"[Security
Solution] Fixes certain Related Integrations showing as `not installed`
even when they are (#149646)\n\n## Summary\r\n\r\nResolves
#149644 by adding a\r\nfallback
for package policies without a
policy_template.","sha":"ba5634eda6b18ae3d809ba50d21878526c97a8dc","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Endpoint
Response","Feature:Detection Rules","Team:
SecuritySolution","Team:Detection
Rules","backport:prev-minor","v8.6.0","v8.7.0","v8.8.0"],"number":149646,"url":"https://github.com/elastic/kibana/pull/149646","mergeCommit":{"message":"[Security
Solution] Fixes certain Related Integrations showing as `not installed`
even when they are (#149646)\n\n## Summary\r\n\r\nResolves
#149644 by adding a\r\nfallback
for package policies without a
policy_template.","sha":"ba5634eda6b18ae3d809ba50d21878526c97a8dc"}},"sourceBranch":"main","suggestedTargetBranches":["8.6","8.7"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/149646","number":149646,"mergeCommit":{"message":"[Security
Solution] Fixes certain Related Integrations showing as `not installed`
even when they are (#149646)\n\n## Summary\r\n\r\nResolves
#149644 by adding a\r\nfallback
for package policies without a
policy_template.","sha":"ba5634eda6b18ae3d809ba50d21878526c97a8dc"}}]}]
BACKPORT-->

Co-authored-by: Garrett Spong <[email protected]>
@nicpenning
Copy link

Any chance this will resolve this issue: #150968 ?

@spong
Copy link
Member Author

spong commented Feb 20, 2023

I don't think so @nicpenning -- as far as I could tell this was only specific to the Elastic Defend integration / when a policy_template would be missing.

Looks like #150968 and #149970 are the same though, so I'll try and get those fixed this week for 8.7 (will backport as far back as I can, but can't make any promises 🙂).

@nicpenning
Copy link

Thanks for the update! I see more of these starting to pop up in the community chat, but I am sure they will get resolved over time.

I greatly appreciate the responses/feedback on these issues as it gives me and others viewing this a sense of confidence that you and others at Elastic are focused on improving the product every day.

@spong
Copy link
Member Author

spong commented Feb 20, 2023

I greatly appreciate the responses/feedback on these issues as it gives me and others viewing this a sense of confidence that you and others at Elastic are focused on improving the product every day.

Thank you @nicpenning, it means a lot! I'm so happy to have such an engaged and active community -- so thank you for your patience and also for your presence/proactiveness here and in the community chat.

This was referenced Feb 22, 2023
Closed
Closed
@banderror banderror added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Feature:Related Integrations Security Solution Detection Rules Related Integrations feature and removed Feature:Detection Rules Security Solution rules and Detection Engine labels Feb 22, 2023
@banderror banderror mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximpn maximpn maximpn approved these changes

Assignees

@spong spong

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Feature:Related Integrations Security Solution Detection Rules Related Integrations feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. release_note:fix Team:Detection Rule Management Security Detection Rule Management Team Team:Endpoint Response Endpoint Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0 v8.6.3 v8.7.0 v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Related Integration shows as not installed even when it is
7 participants
@spong @elasticmachine @kibana-ci @kibanamachine @nicpenning @maximpn @banderror