-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Create open API specification for run connector #149274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
docs
Feature:Actions/ConnectorsManagement
Issues related to Connectors Management UX
v8.7.0
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
labels
Jan 20, 2023
Pinging @elastic/response-ops (Team:ResponseOps) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
szabosteve
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 26, 2023
(cherry picked from commit f78236a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
that referenced
this pull request
Jan 26, 2023
#149614) # Backport This will backport the following commits from `main` to `8.6`: - [[DOCS] Create open API specification for run connector (#149274)](#149274) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-01-26T16:53:47Z","message":"[DOCS] Create open API specification for run connector (#149274)","sha":"f78236a2e4c1532a9a135444bea95a0f89d1047e","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Team:ResponseOps","docs","Feature:Actions/ConnectorsManagement","backport:prev-minor","v8.7.0"],"number":149274,"url":"https://github.com/elastic/kibana/pull/149274","mergeCommit":{"message":"[DOCS] Create open API specification for run connector (#149274)","sha":"f78236a2e4c1532a9a135444bea95a0f89d1047e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/149274","number":149274,"mergeCommit":{"message":"[DOCS] Create open API specification for run connector (#149274)","sha":"f78236a2e4c1532a9a135444bea95a0f89d1047e"}}]}] BACKPORT--> Co-authored-by: Lisa Cawley <[email protected]>
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
docs
Feature:Actions/ConnectorsManagement
Issues related to Connectors Management UX
release_note:enhancement
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v8.6.1
v8.7.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Relates to #137240
This PR creates an open API specification for the run connector API.
NOTE:
When I try to group the possible actions by connector, I receive warnings during linting, seemingly because the same action type (e.g.
pushToService
orgetChoices
) can be used for multiple connector types with differingsubActionParams
and there is no associated connector type parameter to distinguish which are valid together.The linting warnings looked like this:
Therefore, I have grouped the options by subAction type instead.