[Logs UI] Prevent summary request from piling up #148670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
bug
|
Ha, nice! Do you think it would be possible to get a backport of this to We are suffering from this quite a bit. A single user enabling log streaming without filters can overload the entire cluster for us. |
|
@StephanErb it would be pretty easy to backport to earlier 8.x versions. There are no releases for 6.x planned, so I'd prefer not to touch that branch. |
|
Oh. I meant 8.6.x :) |
weltenwort
added
the
backport:prev-minor
|
hehe, ok. sure, I'll backport it to 8.6 |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: cc @weltenwort |
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
tonyghiani
approved these changes
Jan 12, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 12, 2023
Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit f01a61b)
kibanamachine
added a commit
that referenced
this pull request
Jan 12, 2023
…8792) # Backport This will backport the following commits from `main` to `8.6`: - [[Logs UI] Prevent summary request from piling up (#148670)](#148670) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Felix Stürmer","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-01-12T11:04:05Z","message":"[Logs UI] Prevent summary request from piling up (#148670)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"f01a61b81ab0a4756dfe40233aa61a196aa64dbe","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Feature:Logs UI","Team:Infra Monitoring UI","backport:prev-minor","v8.7.0"],"number":148670,"url":"https://github.com/elastic/kibana/pull/148670","mergeCommit":{"message":"[Logs UI] Prevent summary request from piling up (#148670)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"f01a61b81ab0a4756dfe40233aa61a196aa64dbe"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/148670","number":148670,"mergeCommit":{"message":"[Logs UI] Prevent summary request from piling up (#148670)\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"f01a61b81ab0a4756dfe40233aa61a196aa64dbe"}}]}] BACKPORT--> Co-authored-by: Felix Stürmer <[email protected]>
jennypavlova
pushed a commit
to jennypavlova/kibana
that referenced
this pull request
Jan 13, 2023
Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This prevents the execution of new log stream summary requests until the previous request has finished.
related to #86439
🕵️♀️ Review notes
Currently, the
useLogSummaryhook executes new summary requests when any of the parameters change. If parameter changes arrive quicker than the summary requests complete, they will pile up. While theuseCancellableEffectprevented the requests from overtaking each other, the old in-flight requests would still put load on the cluster.Ideally we would re-implement the summary fetching as cancellable async searches. But since we're going to change the orchestration of log stream requests soon anyway (as part of #134412), that would be wasteful. So this is an intermediate improvement to reduce the cluster load.
The changes to the
use_observable.tscollection of hooks are twofold:useBehaviorSubjectdidn't keep the identity of the second return value (thenextfunction) stable, which could lead to undesired re-rendering.useReplaySubjecthook is similar to the improveduseBehaviorSubject, but powered by a n RxJSReplaySubject, which doesn't have an initial value.🩺 How to test
/api/log_entries/summarytake longer than the refresh interval