Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Create open API specification for update/get/delete rule #147407

Merged
merged 12 commits into from
Jan 10, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 13, 2022

Summary

Relates to #137240, #144566

This PR adds the new last_run and next_run properties to the update rule API and get rule API docs.

It also creates the open API specification for the update rule, get rule, and delete rule APIs.

@github-actions
Copy link
Contributor

Documentation preview:

@lcawl lcawl added Feature:Alerting docs v8.7.0 8.6.1 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Dec 13, 2022
@lcawl lcawl marked this pull request as ready for review December 13, 2022 16:58
@lcawl lcawl requested review from a team as code owners December 13, 2022 16:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl mentioned this pull request Dec 13, 2022
7 tasks
@lcawl lcawl marked this pull request as draft December 13, 2022 22:10
@lcawl lcawl marked this pull request as ready for review December 14, 2022 16:20
@lcawl lcawl enabled auto-merge (squash) December 16, 2022 17:45
@lcawl lcawl changed the title [DOCS] Create open API specification for update rule [DOCS] Create open API specification for update/get/delete rule Jan 5, 2023
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit d35296e into elastic:main Jan 10, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 10, 2023
@lcawl lcawl deleted the update-rule branch January 10, 2023 18:40
@lcawl lcawl removed the backport:skip This commit does not require backporting label Jan 10, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jan 10, 2023
@lcawl lcawl added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Jan 10, 2023
lcawl added a commit to lcawl/kibana that referenced this pull request Jan 10, 2023
@lcawl
Copy link
Contributor Author

lcawl commented Jan 10, 2023

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Jan 10, 2023
…148679)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[DOCS] Create open API specification for update rule
(#147407)](#147407)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-01-10T17:27:58Z","message":"[DOCS]
Create open API specification for update rule
(#147407)","sha":"d35296ea3b5390e6ee5d3d6163abc27161c2c778","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Alerting","release_note:skip","Team:ResponseOps","docs","backport:prev-minor","v8.7.0","8.6.1"],"number":147407,"url":"https://github.com/elastic/kibana/pull/147407","mergeCommit":{"message":"[DOCS]
Create open API specification for update rule
(#147407)","sha":"d35296ea3b5390e6ee5d3d6163abc27161c2c778"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/147407","number":147407,"mergeCommit":{"message":"[DOCS]
Create open API specification for update rule
(#147407)","sha":"d35296ea3b5390e6ee5d3d6163abc27161c2c778"}}]}]
BACKPORT-->
jennypavlova pushed a commit to jennypavlova/kibana that referenced this pull request Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.1 v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants