Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS #145606

Merged
merged 2 commits into from
Nov 21, 2022
Merged

Update CODEOWNERS #145606

merged 2 commits into from
Nov 21, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 17, 2022

Summary

Relates to #137240

As we start generating alerting and connector APIs from open API specifications, it is a good idea to require review of any changes to those API docs.

This PR also removes mandatory review for non-API-related responseOps documentation, since it seemed like an unnecessary extra step in that case.

@lcawl lcawl marked this pull request as ready for review November 17, 2022 23:33
@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Nov 17, 2022
@lcawl lcawl requested a review from mikecote November 21, 2022 16:37
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 109 115 +6
securitySolution 443 449 +6
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 110 117 +7
securitySolution 520 526 +6
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit 11f9505 into main Nov 21, 2022
@lcawl lcawl deleted the lcawl-patch-1 branch November 21, 2022 21:16
@kibanamachine kibanamachine added v8.7.0 backport:skip This commit does not require backporting labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants