Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tsd from v0.20.0 to v0.24.1 #144010

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

watson
Copy link
Contributor

@watson watson commented Oct 26, 2022

This PR is to mainly bring main up to date with 7.17 so that it runs the same version of tsd (because we're bumping tsd in 7.17 in this PR: #144008). I guess I should have done the PR's in the other order and then just backported, but at the time I was only focused on fixing something in 7.17.

The tsd package is used by packages/elastic-safer-lodash-set and packages/kbn-utility-types. The only breaking changes according to the docs are that it now requires a newer Node.js version, which we adhere to. Since this is used as part of our test suite, I'd say that as long as the tests pass, we should be ok.

Blocked by

@watson watson added release_note:skip Skip the PR/issue when compiling release notes v8.6.0 v8.5.1 labels Oct 26, 2022
@watson watson requested review from a team October 26, 2022 09:50
@watson watson self-assigned this Oct 26, 2022
@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 31, 2022

💔 Build Failed

Failed CI Steps

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 443 +4
total +17

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 520 +4
total +18

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @watson

@watson watson requested a review from dgieselaar November 1, 2022 09:17
@watson
Copy link
Contributor Author

watson commented Nov 1, 2022

@dgieselaar After upgrading tsd it's saying that there's a TypeScript error in packages/kbn-utility-types/src/dot.ts which according to the CODEOWNERS file you "own". I've not been able to figure out how to fix what it's complaining about (see the "Checks" CI check or run node scripts/kbn run-in-packages test locally on this PR branch). Could I get you to have a look?

@dgieselaar
Copy link
Member

@watson is this version of tsd compatible with the typescript version (4.6) we are using in the repo? It seems to use 4.8? https://github.com/SamVerschueren/tsd/releases/tag/v0.23.0

@watson
Copy link
Contributor Author

watson commented Nov 3, 2022

@dgieselaar Do you think the version we use has to match the @tsd/typescript version that tsd depends on? I can't find anything about it in their documentation 🤷

@dgieselaar
Copy link
Member

@watson I would think so yeah, otherwise we get different errors from CLI type check/IDE on one side vs TS tests, which I think is what we are seeing here.

@watson
Copy link
Contributor Author

watson commented Nov 7, 2022

Ok 👍 I've marked this PR as blocked by #144469

@watson watson added the blocked label Nov 7, 2022
@watson watson marked this pull request as draft January 18, 2023 12:35
@azasypkin azasypkin removed the request for review from a team February 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked release_note:skip Skip the PR/issue when compiling release notes v8.5.1 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants