-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump tsd from v0.20.0 to v0.24.1 #144010
base: main
Are you sure you want to change the base?
Bump tsd from v0.20.0 to v0.24.1 #144010
Conversation
💔 Build FailedFailed CI StepsMetrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @watson |
@dgieselaar After upgrading |
@watson is this version of tsd compatible with the typescript version (4.6) we are using in the repo? It seems to use 4.8? https://github.com/SamVerschueren/tsd/releases/tag/v0.23.0 |
@dgieselaar Do you think the version we use has to match the |
@watson I would think so yeah, otherwise we get different errors from CLI type check/IDE on one side vs TS tests, which I think is what we are seeing here. |
Ok 👍 I've marked this PR as blocked by #144469 |
This PR is to mainly bring
main
up to date with7.17
so that it runs the same version oftsd
(because we're bumpingtsd
in7.17
in this PR: #144008). I guess I should have done the PR's in the other order and then just backported, but at the time I was only focused on fixing something in7.17
.The
tsd
package is used bypackages/elastic-safer-lodash-set
andpackages/kbn-utility-types
. The only breaking changes according to the docs are that it now requires a newer Node.js version, which we adhere to. Since this is used as part of our test suite, I'd say that as long as the tests pass, we should be ok.Blocked by