Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Adjust detection engine routes codeowners #142570

Merged
merged 1 commit into from
Oct 5, 2022
Merged

[Security Solution] Adjust detection engine routes codeowners #142570

merged 1 commit into from
Oct 5, 2022

Conversation

xcrzx
Copy link
Contributor

@xcrzx xcrzx commented Oct 4, 2022

Summary

Split ownership over the security_solution/server/lib/detection_engine/routes/rules folder between several areas.

@xcrzx xcrzx added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Solution Platform Security Solution Platform Team Team:Detection Rule Management Security Detection Rule Management Team Team:Detection Alerts Security Detection Alerts Area Team labels Oct 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

banderror
banderror approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xcrzx Thank you for working on this improvement. I'm fine with both options: merging this PR and delaying until we do the folder restructure. Up to you and other reviewers!

.github/CODEOWNERS
Comment on lines +507 to +511
/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/create_rule_exceptions_route* @elastic/security-solution-platform
/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/find_rule_exceptions_route* @elastic/security-solution-platform
/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/import_rules_route* @elastic/security-solution-platform
/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/preview_rules_route* @elastic/security-detections-response-alerts
/x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules/utils @elastic/security-solution-platform
Copy link
Contributor

@banderror banderror Oct 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this workaround if it saves us some time short-term (like, this week), but long-term this approach is not really scalable and hardly maintainable. We won't be able to keep up with every file being added/deleted/moded/renamed/split and reflect this in the CODEOWNERS file.

I think we will be able to move stuff from the /x-pack/plugins/security_solution/server/lib/detection_engine/routes/rules folder to subdomains very soon (On Week!) as part of our subdomains efforts (#138600).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Reorganizing our codebase is a much better approach. Hopefully, we'll have a chance to implement it soon. Meanwhile, we could merge this PR, as it might save us a few review pings.

@xcrzx xcrzx merged commit 32b029e into elastic:main Oct 5, 2022
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 5, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@xcrzx @WafaaNasr
Adjust detection engine routes codeowners (elastic#142570)
44c6c24
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@xcrzx @WafaaNasr
Adjust detection engine routes codeowners (elastic#142570)
7d6a449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banderror banderror banderror approved these changes

@yctercero yctercero Awaiting requested review from yctercero

@marshallmain marshallmain Awaiting requested review from marshallmain

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Alerts Security Detection Alerts Area Team Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xcrzx @elasticmachine @banderror @kibanamachine