Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Detections] adds missing bulk edit data view tests #141915

Merged
merged 4 commits into from
Sep 28, 2022
Merged

[Security Solution][Detections] adds missing bulk edit data view tests #141915

merged 4 commits into from
Sep 28, 2022

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Sep 27, 2022 •
edited by kibanamachine
Loading

Summary

@vitaliidm vitaliidm self-assigned this Sep 27, 2022
@vitaliidm vitaliidm added test-coverage issues & PRs for improving code test coverage Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.5.0 v8.6.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 27, 2022
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Tests #2 / Related integrations installed integrations: Amazon CloudFront, AWS CloudTrail, System, enabled integrations: Amazon CloudFront, Aws Cloudfront, System "before all" hook for "should display a badge with the installed integrations on the rule management page"

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm marked this pull request as ready for review September 27, 2022 15:16
@vitaliidm vitaliidm requested review from a team as code owners September 27, 2022 15:16
@vitaliidm vitaliidm requested a review from maximpn September 27, 2022 15:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@vitaliidm vitaliidm changed the title [Security Solution][Detections] adds missing bulk edit data view cypress tests [Security Solution][Detections] adds missing bulk edit data view tests Sep 27, 2022
dplumlee
dplumlee approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@dplumlee dplumlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

maximpn
maximpn approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vitaliidm vitaliidm merged commit c7301e5 into elastic:main Sep 28, 2022
@vitaliidm vitaliidm deleted the detections/data-view-e2e-tests branch September 28, 2022 12:59
@kibanamachine kibanamachine mentioned this pull request Sep 28, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 28, 2022
@vitaliidm
[Security Solution][Detections] adds missing bulk edit data view tests (
7f9f469 
elastic#141915)

## Summary

- addresses elastic#135201
- adds Data View cypress and integration tests according to [Data view Bulk Edit test plan](https://docs.google.com/document/d/116x7ITTTJQ6cTiwaGK831_f6Ox7XB3qyLiHxC3Cmf8w/edit#heading=h.j583i3o7bg2g) (internal document)
- integration tests were added earlier in elastic#138448

(cherry picked from commit c7301e5)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 29, 2022
@kibanamachine @vitaliidm
[Security Solution][Detections] adds missing bulk edit data view tests (
f3387ad 
#141915) (#142090)

## Summary

- addresses #135201
- adds Data View cypress and integration tests according to [Data view Bulk Edit test plan](https://docs.google.com/document/d/116x7ITTTJQ6cTiwaGK831_f6Ox7XB3qyLiHxC3Cmf8w/edit#heading=h.j583i3o7bg2g) (internal document)
- integration tests were added earlier in #138448

(cherry picked from commit c7301e5)

Co-authored-by: Vitalii Dmyterko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplumlee dplumlee dplumlee approved these changes

@maximpn maximpn maximpn approved these changes

Assignees

@vitaliidm vitaliidm

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. test-coverage issues & PRs for improving code test coverage v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vitaliidm @kibana-ci @elasticmachine @kibanamachine @maximpn @dplumlee