Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Fix link in list of Kibana plugins #141514

Merged
merged 3 commits into from
Sep 23, 2022
Merged

[DOCS] Fix link in list of Kibana plugins #141514

merged 3 commits into from
Sep 23, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 22, 2022 •
edited by kibanamachine
Loading

Summary

Relates to elastic/docs#2518, which is fixing hard-coded links to "master".

This PR changes the URL in the readme from "master" to "current". It also adds an end of line, so that the documentation link is not used in the autogenerated plugin docs.

@github-actions
Copy link
Contributor

Documentation preview:

@lcawl lcawl mentioned this pull request Sep 22, 2022
Open
20 tasks
@lcawl lcawl marked this pull request as ready for review September 22, 2022 20:35
@lcawl lcawl requested a review from a team as a code owner September 22, 2022 20:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@lcawl lcawl added the release_note:skip Skip the PR/issue when compiling release notes label Sep 22, 2022
gchaps
gchaps approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

ymao1
ymao1 approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit 2892481 into elastic:main Sep 23, 2022
@lcawl lcawl deleted the master-links1 branch September 23, 2022 18:31
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 23, 2022
@lcawl
[DOCS] Fix link in list of Kibana plugins (elastic#141514)
f6712a6 
(cherry picked from commit 2892481)
kibanamachine added a commit that referenced this pull request Sep 23, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141701)
764d638 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
kibanamachine added a commit that referenced this pull request Sep 23, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141696)
2ccd58e 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
lcawl added a commit that referenced this pull request Sep 26, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141703)
5a2bc21 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 27, 2022
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

14 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

jbudz pushed a commit that referenced this pull request Oct 18, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141700)
cdfef2a 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
jbudz pushed a commit that referenced this pull request Oct 18, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141699)
8c0fc90 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
jbudz pushed a commit that referenced this pull request Oct 18, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141698)
9a393b7 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
jbudz pushed a commit that referenced this pull request Oct 18, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141697)
43372b9 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
jbudz pushed a commit that referenced this pull request Oct 18, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141695)
52b1a7e 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
jbudz pushed a commit that referenced this pull request Oct 18, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141691)
9f11ac4 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
jbudz pushed a commit that referenced this pull request Oct 18, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141692)
8e32615 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
jbudz pushed a commit that referenced this pull request Oct 18, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141694)
9f3ec91 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
jbudz pushed a commit that referenced this pull request Oct 18, 2022
@kibanamachine @lcawl
[DOCS] Fix link in list of Kibana plugins (#141514) (#141693)
2e547b9 
(cherry picked from commit 2892481)

Co-authored-by: Lisa Cawley <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps approved these changes

@ymao1 ymao1 ymao1 approved these changes

Assignees
No one assigned
Labels
docs release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.12.2 v7.13.5 v7.14.3 v7.15.3 v7.16.4 v7.17.7 v8.0.2 v8.1.4 v8.2.4 v8.3.4 v8.4.3 v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lcawl @elasticmachine @kibana-ci @kibanamachine @ymao1 @gchaps