Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Data Views] - Update bulk actions data views index param to be snake_case #138304

Merged
merged 5 commits into from
Aug 9, 2022

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Aug 8, 2022

Summary

Overlooked a param name - should be snake case per our APIs. overwriteDataViews --> overwrite_data_views

Testing

  • Create 2 or more rules, one of which uses data views
  • Select to bulk edit 2 or more rules, one of which uses data views
  • Select to bulk add index, do not select any checkboxes and save --> rule with data view should remain using data view
  • Select to bulk add index, select to overwrite rules with data views --> rule with data view should now indicate it is using added index pattern

Screen Shot 2022-08-08 at 10 56 09 AM

Checklist

  • Documentation was added for features that require explanation or tutorials
    • In talks with docs team about new data views changes, this is part of the documentation
  • Unit or functional tests were updated or added to match the most common scenarios

For maintainers

@yctercero yctercero requested review from a team as code owners August 8, 2022 17:59
@yctercero yctercero requested a review from banderror August 8, 2022 17:59
@yctercero yctercero self-assigned this Aug 8, 2022
@yctercero yctercero added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed Team:Security Solution Platform Security Solution Platform Team v8.4.0 v8.5.0 ci:cloud-deploy Create or update a Cloud deployment labels Aug 8, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @yctercero, we overlooked that too.

The diff LGTM. I also tested it locally and it works 👍
Except for the failing integration test, this should be ready for merge.

One question: I didn't find this overwrite_data_views or overwriteDataViews request parameter documented in https://www.elastic.co/guide/en/security/master/bulk-actions-rules-api.html. Do we have a ticket in https://github.com/elastic/security-docs for documenting it? Do you think it's ready to be documented?

@banderror
Copy link
Contributor

Btw I don't know if you've seen the update but the auto-backport label is not necessary anymore

@yctercero
Copy link
Contributor Author

Thanks @banderror ! I'm updating the integration test now. As far as documenting, it is being worked on here by the docs team as part of the new data views in rule creation work.

@yctercero yctercero removed the auto-backport Deprecated - use backport:version if exact versions are needed label Aug 8, 2022
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for the info @yctercero! 🚀

@yctercero yctercero requested a review from a team as a code owner August 9, 2022 01:48
@yctercero yctercero removed the request for review from a team August 9, 2022 01:53
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 5.6MB 5.6MB +2.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 254.7KB 254.7KB +2.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 9, 2022
…x param to be snake_case (elastic#138304)

## Summary

Overlooked a param name - should be snake case per our APIs. `overwriteDataViews` --> `overwrite_data_views`

(cherry picked from commit bad17a1)
@jbudz
Copy link
Member

jbudz commented Aug 9, 2022

This was reverted with 0bc8cf7.

https://buildkite.com/elastic/kibana-on-merge/builds/19628#01828304-8026-49d9-99a5-407b61da7e98

@jbudz jbudz added the reverted label Aug 9, 2022
@banderror
Copy link
Contributor

Hey @yctercero I think you needed to rebase against main and resolve some conflicts before merging this one.

@yctercero yctercero deleted the update_data_view_bulk_param branch August 9, 2022 16:30
kibanamachine pushed a commit to JordanSh/kibana that referenced this pull request Aug 10, 2022
…atterns (elastic#138435)

**Ticket:** elastic#138409
**Caused by:** elastic#138304 (comment)

## Summary

The merge of elastic#138304 caused unit tests for bulk editing index patterns to start failing. This PR was reverted by elastic@0bc8cf7. The tests were skipped in elastic@26a4783.

These tests are fully functional in `main`. Unskipping them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes reverted Team:Security Solution Platform Security Solution Platform Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.4.0 v8.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants