Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to v60.3.0 #136405

Merged
merged 12 commits into from
Jul 21, 2022
Merged

Upgrade EUI to v60.3.0 #136405

merged 12 commits into from
Jul 21, 2022

Conversation

breehall
Copy link
Contributor

Summary

[email protected][email protected]

60.3.0

  • EuiDataGrid's imperative API now exposes the scrollTo and scrollToItem APIs of react-window. (#6042)

Bug fixes

  • Fixed drag and drop interactions on EuiAccordion elements (#6031)
  • Fixed EuiDataGrid's row count/indices announced to screen readers when virtualized (#6033)
  • Fixed EuiDataGrid's current cell row/column position announced to screen readers when sorted and paginated, and also improved column identification and announcement cadence (#6033)
  • Fixed EuiContextMenuPanelDescriptor's width prop type to correctly reflect that it allows all CSS width values, not just numbers (#6043)
  • Fixed EuiSelectable onChange keyboard events not being correctly passed back on React v16 (#6045)

60.2.0

  • Added cluster, container, kubernetesNode, kubernetesPod and namespace glyphs to EuiIcon (#6001)
  • Added a default title to EuiDataGrid's column headers, allowing header text to remain visible if truncated due to column widths (#6013)
  • Added a popoverScreenReaderText prop to EuiPopover that allows customizing screen reader instructions when a popover first opens (#6017)
  • Enhanced EuiDataGrid's column header actions popover to be keyboard navigable via up/down arrow keys (#6017)
  • EuiDataGrid now accepts a virtualizationOptions.onItemsRendered callback, as well as virtualizationOptions.className (#6019)

Bug fixes

  • Fixed the focus context of EuiDataGrid to ensure that focusedCell maintains it's referential integrity. This ensures that React hooks can use this safely as a dependency. (#6007)
  • Fixed buggy EuiDataGrid column header display on sorted columns with no actions (#6014)
  • Fixed EuiPopover unintentionally passing the offset prop as an HTML attribute to its div wrapper (#6017)
  • Fixed EuiDataGrid focus/scroll jumping occurring when the first interaction the user had with the grid was the scrollbar(s) (#6018)

@thompsongl
Copy link
Contributor

thompsongl commented Jul 19, 2022

retry.tryForTime timeout: Error: Cell text should match pattern '/^(.*)Row: (\d+); Column: (\d+)$/'

These look like valid failures. Apparently we changed the text pattern and it no longer matches the regex in these two test suites.
New pattern: https://github.com/elastic/eui/pull/6033/files#diff-f94afd70516f335607633b35d1d4840153dfd528af2e01b017ff2782c3b0e76dR132

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count 4969 4974 +5
total size 7.7MB 7.7MB +7.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 342.3KB 342.6KB +275.0B
kbnUiSharedDeps-css 533.7KB 533.6KB -159.0B
kbnUiSharedDeps-npmDll 5.1MB 5.1MB +3.4KB
total +3.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl marked this pull request as ready for review July 19, 2022 21:39
@thompsongl thompsongl requested review from a team as code owners July 19, 2022 21:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM.

@breehall breehall merged commit 44f7338 into main Jul 21, 2022
@breehall breehall deleted the eui-60.3.0 branch July 21, 2022 12:28
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants