Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] add back api integration tests and update esArchiver data #126998

Merged
merged 4 commits into from
Mar 8, 2022

Conversation

neptunian
Copy link
Contributor

@neptunian neptunian commented Mar 7, 2022

API integration tests for metricbeat were commented out in #119112 (8.1) temporarily and were not commented back in. After putting them back in, a few fail, because we removed metricbeat-* from the index pattern, but the data in some test archives is still metricbeat-*. This PR comments all the tests back in and updates the data to use the ECS metricbeat data EXCEPT /setup. The setup tests are not as straight forward for testing metricbeat data streams because its mixed with legacy monitoring data in order to figure out states of migration (both legacy and datastream data must exist) so these could not be loaded the same way. This will be done in separate PR.

No tests fail after updating the archive data.

@neptunian neptunian added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Mar 7, 2022
@neptunian neptunian self-assigned this Mar 7, 2022
@neptunian neptunian requested a review from klacabane March 7, 2022 19:04
@neptunian neptunian marked this pull request as ready for review March 7, 2022 23:29
@neptunian neptunian requested a review from a team as a code owner March 7, 2022 23:29
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@neptunian
Copy link
Contributor Author

@elasticmachine merge upstream

@neptunian neptunian added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels Mar 7, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @neptunian

Copy link
Contributor

@matschaffer matschaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if there's a great way to inspect the archive contents, but this LGTM just based on an in-browser review and CI passing.

@neptunian
Copy link
Contributor Author

@matschaffer Thanks. I just used @klacabane's script https://gist.github.com/klacabane/1bcddbee8c04161ac56d2d1ac2a234e2 as this was all beats data. I've also removed the mappings so it uses the correct ones that come with Kibana.

@matschaffer
Copy link
Contributor

Ah nice! we should probably get that into a doc somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants