-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stack Monitoring] add back api integration tests and update esArchiver data #126998
[Stack Monitoring] add back api integration tests and update esArchiver data #126998
Conversation
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @neptunian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there's a great way to inspect the archive contents, but this LGTM just based on an in-browser review and CI passing.
@matschaffer Thanks. I just used @klacabane's script https://gist.github.com/klacabane/1bcddbee8c04161ac56d2d1ac2a234e2 as this was all beats data. I've also removed the mappings so it uses the correct ones that come with Kibana. |
Ah nice! we should probably get that into a doc somewhere |
API integration tests for metricbeat were commented out in #119112 (8.1) temporarily and were not commented back in. After putting them back in, a few fail, because we removed
metricbeat-*
from the index pattern, but the data in some test archives is stillmetricbeat-*
. This PR comments all the tests back in and updates the data to use the ECS metricbeat data EXCEPT /setup. The setup tests are not as straight forward for testing metricbeat data streams because its mixed with legacy monitoring data in order to figure out states of migration (both legacy and datastream data must exist) so these could not be loaded the same way. This will be done in separate PR.No tests fail after updating the archive data.