-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kql] Remove named args and unused geo functions #118973
Conversation
Pinging @elastic/kibana-app-services (Team:AppServicesSv) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm 👍
thanks for the deep dive explaining it
Code owners were not trigger. I think we need to add that package to |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: cc @lukasolson |
💔 Backport failed
To backport manually run: |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
1 similar comment
Friendly reminder: Looks like this PR hasn’t been backported yet. |
* [kql] Remove named args and unused geo functions * Fix tests * Re-format grammar output
Summary
kuery
) grammar & types by removing thenamedArg
node type.geo_bounding_box
andgeo_polygon
KQL functions.The
namedArg
node type was used only by therange
function to specify which operator was being used (<
,<=
,>
, or>=
). This was not necessary, as it can just be an additional argument to the function itself. Note that many of the tests that previously contained multiple inequality conditions were updated to only include one, as the grammar itself only supports this.The
geo_bounding_box
andgeo_polygon
functions were vestiges of the very first version of the (experimental) Kibana query language (which was actually known as "Kuery"). These aren't supported in the current version of KQL (and haven't been for years).Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers