[Security Solutions] Fixes jest test memory leaks within the server side detection engine #117964
Conversation
| import { | ||
|
|
||
| // We _must_ import from here and not from "alerting/server" above or we will get a memory leak. See https://github.com/elastic/kibana/issues/117255 | ||
| import { parseDuration } from '../../../../../alerting/common/parse_duration'; |
There was a problem hiding this comment.
NOTE: Here is one key area where I had to import as a workaround for the memory leaks found by importing at a higher level within alerting.
FrankHassanabad
added
v8.0.0
v8.1.0
release_note:skip
|
|
||
| // We have to disable this path otherwise we leak memory and cannot directly import from "../../../../../../actions/server/" | ||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | ||
| import { actionsClientMock } from '../../../../../../actions/server/actions_client.mock'; |
There was a problem hiding this comment.
NOTE: I have to use this and cannot use import { actionsClientMock } from '../../../../../../actions/server/mocks'; without having a memory leak within Jest.
There was a problem hiding this comment.
Is there anyway we can add a linter rule to this and the above infringing mocks to prevent folks from importing them this way in the future (or warn at least?), or best just to prioritize identifying and fixing the underlying issues? Just curious what we can do to prevent these memory leaks from slowly sneaking their way back in... 🐌💧
There was a problem hiding this comment.
I am thinking that maybe this isn't the right way for us to go here. I am thinking of putting this back into draft mode and talking to more operations people. The module loader in some cases looks to be re-loading or leaking the modules and handling this at an infrastructure level might be better for us.
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
Summary
Fixes the jest memory leaks within (in a workaround way) within:
See these comments:
#117255 (comment)
#117255 (comment)
On how those two issues were worked around.
Other things is I did a
import typeeverywhere I could within thedetection_engineto reduce chances of other memory leaks from imports.How to test this memory leak has been fixed?
You can run as low as 600 megs for space size here. If you try to use a different branch such as main, it will not complete in under 600 megs and will blow up.
Checklist