-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Log TM health and drift stats prior to reporting tests #117013
[Reporting] Log TM health and drift stats prior to reporting tests #117013
Conversation
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the context, I think the reasoning behind this change makes sense. It's not clear what reporting should do differently if TM is unhealthy/unable to claim jobs.
Updated the description to say this PR "Partially addresses #93354" rather than closes it. |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
…lastic#117013) * [Reporting] Log TM health and drift stats prior to reporting tests Closes elastic#114946 * re-skip flaky test * rename method
…lastic#117013) * [Reporting] Log TM health and drift stats prior to reporting tests Closes elastic#114946 * re-skip flaky test * rename method
…lastic#117013) * [Reporting] Log TM health and drift stats prior to reporting tests Closes elastic#114946 * re-skip flaky test * rename method
Closes #114946
Partially addresses #93354
Looking at the test failures for "Reporting APIs BWC report generation urls Pre 6_2 job posted successfully" showed logs where the task for the report was never claimed, due to health problems with Task Manager.
This PR addresses the problem by adding TM health stats to the logs prior to running the reporting tests. If the test continues to be flaky, we should look at the TM logs and see if the there was a problem with Task Manager at the time.