[Uptime] Run Sample uptime tests using @elastic/synthetics #112128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
force-pushed
the
playwright-ftr-e2e
branch
from
611d314 to
12a8125
Compare
shahzad31
changed the title
shahzad31
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
added
the
release_note:skip
|
@elasticmachine merge upstream |
shahzad31
commented
Sep 22, 2021
| @@ -70,5 +68,5 @@ const canvasWebpack = { | |||
| module.exports = { | |||
| ...defaultConfig, | |||
| addons: [...(defaultConfig.addons || []), './addon/target/register'], | |||
| webpackFinal: (config: Configuration) => webpackMerge(config, canvasWebpack), | |||
| webpackFinal: (config) => webpackMerge(config, canvasWebpack), | |||
| }; | |||
There was a problem hiding this comment.
build was breaking with ts usage here.
Comment on lines
15
to
35
| // async function refreshUptimeApp() { | ||
| // while (!(await page.$('div.euiBasicTable'))) { | ||
| // await page.click('[data-test-subj=superDatePickerApplyTimeButton]'); | ||
| // // eslint-disable-next-line no-console | ||
| // console.log('refreshing uptime app'); | ||
| // await page.waitForTimeout(5 * 1000); | ||
| // } | ||
| // } | ||
| // | ||
| // async function waitForKibanaToLoad() { | ||
| // let isStillLoading = true; | ||
| // | ||
| // while (isStillLoading) { | ||
| // const welcomeMessage = await page.$('text="Welcome to Elastic"'); | ||
| // isStillLoading = welcomeMessage === null; | ||
| // if (isStillLoading) { | ||
| // await page.reload(); | ||
| // await page.waitForTimeout(10 * 1000); | ||
| // } | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Any reason to keep this?
| } | ||
| } | ||
|
|
||
| step('Go to Kibana', async () => { |
There was a problem hiding this comment.
Suggested change
| step('Go to Kibana', async () => { | |
| step('Go to Kibana', async () => { |
| await page.goto(`${params.kibanaUrl}/app/uptime?dateRangeStart=now-5y&dateRangeEnd=now`, { | ||
| waitUntil: 'networkidle', | ||
| }); | ||
| // await waitForKibanaToLoad(); |
There was a problem hiding this comment.
Delete this if there's no reason to keep it.
Suggested change
| // await waitForKibanaToLoad(); |
|
|
||
| step('Check if there is table data', async () => { | ||
| await page.click('[data-test-subj=uptimeOverviewPage]'); | ||
| // await refreshUptimeApp(); |
There was a problem hiding this comment.
Suggested change
| // await refreshUptimeApp(); |
| await page.click('[data-test-subj=monitor-page-link-0001-up]'); | ||
| }); | ||
|
|
||
| step('It navigates to details page', async () => { |
There was a problem hiding this comment.
I think we can dispense with naming the step "It..." as that's typically assumed by it step test, etc.
Suggested change
| step('It navigates to details page', async () => { | |
| step('Navigates to details page', async () => { |
| const result = await playwrightStart(getService); | ||
|
|
||
| if (result && result.uptime.status !== 'succeeded') { | ||
| process.exit(1); |
There was a problem hiding this comment.
Perhaps including an error message here is also a good idea, and perhaps a success message in an else block?
There was a problem hiding this comment.
@elastic/synthetics logs those messages be default, this is just a formality to push the exit code to the CI
| } | ||
|
|
||
| async function playwrightStart(getService: any) { | ||
| console.log('Loading esArchiver...'); |
There was a problem hiding this comment.
Is there a logger utility Kibana exposes for us to call instead of bare console.log? It looks kinda weird in the output. Not a huge deal, esp. for v1, but if it's easy it could be nicer to improve this.
There was a problem hiding this comment.
defenitely something worth doing in a follow up, probably we will use junit output to hook the logs into jenkins ci
There was a problem hiding this comment.
Can we add an enhancement issue then to make sure we don't lose track of it? Should be a fairly light addition someone can implement when they have time.
There was a problem hiding this comment.
Sure, i will add that.
tylersmalley
approved these changes
Sep 23, 2021
crob611
suggested changes
Sep 23, 2021
There was a problem hiding this comment.
I don't like just changing files from .ts to .js to "fix" whatever problem has come up.
The typescript errors look to be originating from the ts-node package, which is newly introduced by this PR. I would rather we identify why adding the ts-node package suddenly starts breaking this PR build, and to ensure there's not other side effects happening somewhere, rather than just ignore it.
|
@elasticmachine merge upstream |
shahzad31
commented
Sep 29, 2021
Comment on lines
-17
to
-19
| webpackFinal: (config: Configuration) => { | ||
| return WebpackConfig({ config }); | ||
| }, |
There was a problem hiding this comment.
webpackFinal usage in storybook main.ts somehow is causing issues with newly added dependency of ts-node most likely an issue with storybook typescript setup
shahzad31
commented
Sep 29, 2021
Comment on lines
-15
to
-17
| webpackFinal: (config: Configuration) => { | ||
| return WebpackConfig({ config }); | ||
| }, |
There was a problem hiding this comment.
webpackFinal usage in storybook main.ts somehow is causing issues with newly added dependency of ts-node most likely an issue with storybook typescript setup
shahzad31
commented
Sep 29, 2021
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
joshdover
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Fleet storybook changes seem good, but would like @clintandrewhall to verify before merging
clintandrewhall
approved these changes
Sep 29, 2021
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Performance Tests.x-pack/test/performance/tests/reporting_dashboard·ts.performance reporting dashbaord downloaded PDF has OK statusStandard OutStack TraceMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @shahzad31 |
shahzad31
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2021
…12128) Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added
the
backport missing
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
kibanamachine
added a commit
that referenced
this pull request
Oct 4, 2021
…2128) (#113531) * [Uptime] Run Sample uptime tests using @elastic/synthetics (#112128) Co-authored-by: Kibana Machine <[email protected]> * update test according to 7.x * revert Co-authored-by: Shahzad <[email protected]> Co-authored-by: shahzad31 <[email protected]>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #112777
This is a follow up to #90673
Integerated @elastic/synthetics based test runner to run uptime e2e tests sample journeys
To RUN These test
from
x-pack/plugins/uptimeStart server using
node scripts/e2e.js --serverafter server is up we can start the runner using
node scripts/e2e.js --runnerRunner is based on kibana FTR, but to run tests it's using @elastic/synthetics, which is based on playwright.
Data is a loading using esArchiver utility.
CI
It adds a process which only runs when something changes in
x-pack/plugins/uptimeNext
We would like to migrate few of out uptime tests and user experience app test to this runner to judge capabilities and bottlenecs in the @elastic/synthetics product. It's going to be a great dogfooding.