-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NA): moving @kbn/securitysolution-io-ts-list-types to babel transpile #109750
chore(NA): moving @kbn/securitysolution-io-ts-list-types to babel transpile #109750
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any ideas on the bundle size changes?
@jbudz It is related with the way typescript and babel differently transpile TSC
BABEL
I'll search to see if is there anything we can do about this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
- Looked over this PR and everything looks as advertised 👍
fd24c0d
to
c6d75ad
Compare
…uritysolution-io-ts-list-types-with-babel
@elasticmachine merge upstream |
@elasticmachine merge upstream |
…bel' of github.com:mistic/kibana into transpile-kbn-securitysolution-io-ts-list-types-with-babel
@jbudz do you think we are good to go here? |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…nspile (elastic#109750) * chore(NA): moving @kbn/securitysolution-io-ts-list-types to babel transpiler * chore(NA): add a browser target Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…nspile (#109750) (#110296) * chore(NA): moving @kbn/securitysolution-io-ts-list-types to babel transpiler * chore(NA): add a browser target Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]>
One step forward on #69706
That PR moves the @kbn/securitysolution-io-ts-list-types from using tsc compiler to babel transpiler to produce the js outputs.