Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler #109745

Conversation

mistic
Copy link
Member

@mistic mistic commented Aug 23, 2021

One step forward on #69706

That PR moves the @kbn/securitysolution-io-ts-alerting-types from using tsc compiler to babel transpiler to produce the js outputs.

@mistic mistic added chore Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 v7.16.0 v7.14.1 labels Aug 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 6.5MB 6.6MB +34.5KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

  • Looked over this PR and everything looks as advertised 👍

@mistic mistic merged commit 85a79ac into elastic:master Aug 25, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 25, 2021
… transpiler (elastic#109745)

* chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler

* chore(NA): correct deps on runtime
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 25, 2021
… transpiler (elastic#109745)

* chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler

* chore(NA): correct deps on runtime
@kibanamachine
Copy link
Contributor

💔 Backport failed

Status Branch Result
7.15
7.x
7.14 Commit could not be cherrypicked due to conflicts

Successful backport PRs will be merged automatically after passing CI.

To backport manually run:
node scripts/backport --pr 109745

mistic added a commit to mistic/kibana that referenced this pull request Aug 25, 2021
… transpiler (elastic#109745)

* chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler

* chore(NA): correct deps on runtime
# Conflicts:
#	packages/kbn-securitysolution-io-ts-alerting-types/BUILD.bazel
#	packages/kbn-securitysolution-io-ts-alerting-types/tsconfig.json
mistic added a commit that referenced this pull request Aug 25, 2021
… transpiler (#109745) (#110114)

* chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler

* chore(NA): correct deps on runtime
# Conflicts:
#	packages/kbn-securitysolution-io-ts-alerting-types/BUILD.bazel
#	packages/kbn-securitysolution-io-ts-alerting-types/tsconfig.json
kibanamachine added a commit that referenced this pull request Aug 25, 2021
… transpiler (#109745) (#110103)

* chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler

* chore(NA): correct deps on runtime

Co-authored-by: Tiago Costa <[email protected]>
kibanamachine added a commit that referenced this pull request Aug 25, 2021
… transpiler (#109745) (#110104)

* chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler

* chore(NA): correct deps on runtime

Co-authored-by: Tiago Costa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.14.1 v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants