-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler #109745
Merged
mistic
merged 2 commits into
elastic:master
from
mistic:transpile-kbn-securitysolution-io-ts-alerting-types-with-babel
Aug 25, 2021
Merged
chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler #109745
mistic
merged 2 commits into
elastic:master
from
mistic:transpile-kbn-securitysolution-io-ts-alerting-types-with-babel
Aug 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
chore
Team:Operations
Team label for Operations Team
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
auto-backport
Deprecated - use backport:version if exact versions are needed
v7.15.0
v7.16.0
v7.14.1
labels
Aug 23, 2021
Pinging @elastic/kibana-operations (Team:Operations) |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Aug 24, 2021
FrankHassanabad
approved these changes
Aug 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
- Looked over this PR and everything looks as advertised 👍
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 25, 2021
… transpiler (elastic#109745) * chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler * chore(NA): correct deps on runtime
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 25, 2021
… transpiler (elastic#109745) * chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler * chore(NA): correct deps on runtime
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Aug 25, 2021
… transpiler (elastic#109745) * chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler * chore(NA): correct deps on runtime # Conflicts: # packages/kbn-securitysolution-io-ts-alerting-types/BUILD.bazel # packages/kbn-securitysolution-io-ts-alerting-types/tsconfig.json
kibanamachine
added a commit
that referenced
this pull request
Aug 25, 2021
… transpiler (#109745) (#110103) * chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler * chore(NA): correct deps on runtime Co-authored-by: Tiago Costa <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Aug 25, 2021
… transpiler (#109745) (#110104) * chore(NA): moving @kbn/securitysolution-io-ts-alerting-types to babel transpiler * chore(NA): correct deps on runtime Co-authored-by: Tiago Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
chore
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v7.14.1
v7.15.0
v7.16.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step forward on #69706
That PR moves the @kbn/securitysolution-io-ts-alerting-types from using tsc compiler to babel transpiler to produce the js outputs.