-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler #109442
chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler #109442
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
Question: "browser": "./target_web/browser.js", Is that needed/wanted? If so, what is that for? |
@FrankHassanabad that is needed in case the pkg is to be required on browser bundles 😄 |
With regards to: something feels off though as it is trying to point to the file
Should it really be this? "browser": "./target_web/index.js", I think they copied from |
@FrankHassanabad I see, good catch. Changed and pushed! Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
- Looked over this PR and compared it to similar ones and the directory structures to see if anything was overlooked
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
…lastic#109442) * chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler * chore(NA): fix package.json * chore(NA): finetunning package Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # packages/kbn-securitysolution-t-grid/BUILD.bazel # packages/kbn-securitysolution-t-grid/tsconfig.browser.json # packages/kbn-securitysolution-t-grid/tsconfig.json
…lastic#109442) * chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler * chore(NA): fix package.json * chore(NA): finetunning package Co-authored-by: Kibana Machine <[email protected]>
…lastic#109442) * chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler * chore(NA): fix package.json * chore(NA): finetunning package Co-authored-by: Kibana Machine <[email protected]>
…109442) (#109675) * chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler * chore(NA): fix package.json * chore(NA): finetunning package Co-authored-by: Kibana Machine <[email protected]> # Conflicts: # packages/kbn-securitysolution-t-grid/BUILD.bazel # packages/kbn-securitysolution-t-grid/tsconfig.browser.json # packages/kbn-securitysolution-t-grid/tsconfig.json
…109442) (#109676) * chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler * chore(NA): fix package.json * chore(NA): finetunning package Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]>
…109442) (#109677) * chore(NA): moving @kbn/securitysolution-t-grid to babel transpiler * chore(NA): fix package.json * chore(NA): finetunning package Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]>
One step forward on #69706
That PR moves the @kbn/securitysolution-t-grid from using tsc compiler to babel transpiler to produce the js outputs.