-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core.metrics] Add support for multiple processes in ops metrics & stats API; deprecate process field #107900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bamieh
added
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
auto-backport
Deprecated - use backport:version if exact versions are needed
v7.16.0
labels
Aug 9, 2021
joshdover
reviewed
Aug 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General direction here looking good!
Comment on lines
40
to
41
process: mainProcess, | ||
processes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
…ops_multi_process
…ops_multi_process
…ops_multi_process
…ops_multi_process
…ops_multi_process
…ops_multi_process
💔 Build Failed
Failed CI StepsMetrics [docs]Unknown metric groupsAPI count
API count missing comments
History
To update your PR or re-run it, just comment with: |
Bamieh
added a commit
to Bamieh/kibana
that referenced
this pull request
Aug 24, 2021
9 tasks
Closing in favor of #109820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Deprecated - use backport:version if exact versions are needed
release_note:skip
Skip the PR/issue when compiling release notes
v7.16.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. Remaining items until ready:
name
field for each process. So far we only havemain_thread
.histogram.mean
forevent_loop_delay
.Summary
/api/status
Closes #104031