-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NA): moving @kbn/config-schema to babel transpiler #106929
chore(NA): moving @kbn/config-schema to babel transpiler #106929
Conversation
Pinging @elastic/kibana-operations (Team:Operations) |
I didn't hit the build failure locally. I'll reset and see what happens. |
@jbudz I've fixed those |
Were you able to hit the same error? I didn't have any luck after a reset. I'll take another look at my environment, want to make sure I'm actually testing things here. |
Yeah I was able to reproduce it when running |
Why and when we decided to use |
@mshustov we had to change our initial plans due to performance reasons with the tsc compiler \cc @tylersmalley |
@elasticmachine merge upstream |
The build time performance, I guess? These packages aren't rebuilt often. On the whole, is this concern relevant for the Bazel architecture since we rebuilt modules only when they changed? |
@mshustov the problem was the performance plus the fact we cant run the tsc in the transpile only mode. We want to decouple the type generation from the transpilation so we can avoid unnecessary cascading rebuilds when developing on packages. We are considering multiple options at the moment but we already agreed that for now we will use babel as a transpiler for packages |
Ok, let's document this decision in #77303
I believe you can improve performance by opting out of |
@elasticmachine merge upstream |
@mshustov I will let @tylersmalley document our decisions into that issue |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
) * chore(NA): moving @kbn/config-schema to babel transpiler * chore(NA): added runtime deps * chore(NA): update api extractions Co-authored-by: Kibana Machine <[email protected]>
) * chore(NA): moving @kbn/config-schema to babel transpiler * chore(NA): added runtime deps * chore(NA): update api extractions Co-authored-by: Kibana Machine <[email protected]>
…107087) * chore(NA): moving @kbn/config-schema to babel transpiler * chore(NA): added runtime deps * chore(NA): update api extractions Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]>
…107088) * chore(NA): moving @kbn/config-schema to babel transpiler * chore(NA): added runtime deps * chore(NA): update api extractions Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Tiago Costa <[email protected]>
) * chore(NA): moving @kbn/config-schema to babel transpiler * chore(NA): added runtime deps * chore(NA): update api extractions Co-authored-by: Kibana Machine <[email protected]>
One step forward on #69706
That PR moves the @kbn/config-schema from using tsc compiler to babel transpiler to produce the js outputs.