Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Fix flaky download pdf test #105210

Merged

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Jul 12, 2021

Summary

Fix #102722

Unskips a flaky test and adds a retry to ensure that we are on the "dashboards" landing page. Looking at the screenshots of the failure instances we are getting stuck looking for the breadcrumb link to the dashboard home page when we are already on the dashboard home page.

The current implementation retries the check for whether we are on the landing page for a set amount of time, it could be that, on occasion, the check is running to early and we are falling back to looking for the dashboard breadcrumb which we can't find.

@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@jloleysens jloleysens added the release_note:skip Skip the PR/issue when compiling release notes label Jul 12, 2021
@tsullivan
Copy link
Member

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens marked this pull request as ready for review July 14, 2021 11:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@jloleysens jloleysens merged commit 8fb5633 into elastic:master Jul 14, 2021
@jloleysens jloleysens added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 14, 2021
@jloleysens jloleysens deleted the reporting/fix-flaky-download-pdf-test branch July 14, 2021 11:26
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jul 14, 2021
* added a retry for checking that we are on the dashboard landing page

* added .only and removed .skip

* remove .only

* revert this: added .only for flaky test runner

* Remove .only

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 14, 2021
* added a retry for checking that we are on the dashboard landing page

* added .only and removed .skip

* remove .only

* revert this: added .only for flaky test runner

* Remove .only

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Jean-Louis Leysens <[email protected]>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 15, 2021
* added a retry for checking that we are on the dashboard landing page

* added .only and removed .skip

* remove .only

* revert this: added .only for flaky test runner

* Remove .only

Co-authored-by: Kibana Machine <[email protected]>
jloleysens added a commit that referenced this pull request Jul 15, 2021
* added a retry for checking that we are on the dashboard landing page

* added .only and removed .skip

* remove .only

* revert this: added .only for flaky test runner

* Remove .only

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
@sophiec20 sophiec20 added the (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.14.1 v7.15.0 v8.0.0
Projects
None yet
6 participants