Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Reporting] New UI for migrating reporting indices ILM policy (#103853) #104312

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

jloleysens
Copy link
Contributor

Backports the following commits to 7.x:

…c#103853)

* revert revert

* wip; first iteration of server-side functionality

* wip; public side code started. using the new ilm policy status endpoint

* * refactored ReportingIlmPolicyManager -> IlmReportingManager
* restructured files for the policy manager code
* re-added the IlmPolicyStatusResponse interface

* added the ability to use useRequest

* * removed extra server-side endpoint, we do both migration steps
  in one
* added ilm policy context and context for api client
* added es ui shared so we can use userequest

* added working link to ILM policy

* refactor of the migration route response (again), added logic for determining when to show ilm-policy link

* fix type issues and refactor to use testbed pattern for report listing component

* added tests for base cases of ilm policy banner

* remove non-existent prop

* added minor fixes (handling 404 from ES) and added API integration tests

* resolve merge conflict and remove unused file

* update toast error message

Co-authored-by: Kibana Machine <[email protected]>
@jloleysens jloleysens enabled auto-merge (squash) July 5, 2021 14:50
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
reporting 51 59 +8

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
reporting 131 132 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
reporting 64.9KB 70.4KB +5.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
reporting 54.4KB 56.6KB +2.2KB
Unknown metric groups

API count

id before after diff
reporting 132 133 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit b647f23 into elastic:7.x Jul 5, 2021
@jloleysens jloleysens deleted the backport/7.x/pr-103853 branch July 6, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants