-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Updated Kibana alerting/rules language #101977
Conversation
Pinging @elastic/stack-monitoring (Team:Monitoring) |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Thanks! I think what you are changing should actually stay as "alerts" since the dropdown is listing alerts. In "setup mode" we display the rules we would need to toggle between "rules" and alerts" instead of just having "alerts" everywhere. Should be "rules" (setup mode) Should stay "alerts" (not in setup mode) Part of the change is here https://github.com/elastic/kibana/blob/master/x-pack/plugins/monitoring/public/alerts/badge.tsx#L21, but would require usage of the variable @ravikesarwani do you agree? Could have someone on the team do it if you prefer. |
I agree @neptunian . In "fired/active" state we need to refer to it as Alert. |
Thanks for the feedback @ravikesarwani and @neptunian ! |
Thank you so much @lcawl. I reviewed the help available here Kibana alert docs. One piece that has caused confusion to the users is around how to review and modify threshold etc. on the default rules that we have created. This can be added potentially as a Note after "However, you can tailor them to meet your specific needs." so that it's highlighted. Thoughts? |
@ravikesarwani Yes, that's the piece of info that was accidentally omitted from the previous PR. You can see it now in the preview here: https://kibana_101977.docs-preview.app.elstc.co/guide/en/kibana/master/kibana-alerts.html |
Summary
This PR updates Kibana alert docs to remove an out-dated and unnecessary screenshot.