Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove license check from Ingest Node Pipelines UI #100189

Merged
merged 4 commits into from
May 29, 2021
Merged

Remove license check from Ingest Node Pipelines UI #100189

merged 4 commits into from
May 29, 2021

Conversation

cjcenizal
Copy link
Contributor

Partially addresses #97314

@cjcenizal cjcenizal added chore v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes Feature:Ingest Node Pipelines Ingest node pipelines management v7.14.0 labels May 16, 2021
@cjcenizal cjcenizal requested a review from a team as a code owner May 16, 2021 03:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal cjcenizal mentioned this pull request May 16, 2021
Open
7 tasks
yuliacech
yuliacech approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for working on this, @cjcenizal! Tested locally and all worked for me, code changes LGTM too 👍

@cjcenizal
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 390 346 -44
stackAlerts 101 95 -6
total -342

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal cjcenizal merged commit 67b8a43 into elastic:master May 29, 2021
@cjcenizal cjcenizal deleted the ingest-node-pipelines/remove-api-guard branch May 29, 2021 00:13
@cjcenizal cjcenizal mentioned this pull request May 29, 2021
Merged
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request May 29, 2021
@cjcenizal
Remove license check from Ingest Node Pipelines UI (elastic#100189)
cc16331
cjcenizal added a commit that referenced this pull request May 29, 2021
@cjcenizal @kibanamachine
Remove license check from Ingest Node Pipelines UI (#100189) (#100959)
fb14fb0 
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuliacech yuliacech yuliacech approved these changes

Assignees
No one assigned
Labels
chore Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cjcenizal @elasticmachine @kibanamachine @yuliacech