Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security solution] Remove legacy ESQL quick prompt #201276

Merged
merged 11 commits into from
Dec 2, 2024
Merged

[Security solution] Remove legacy ESQL quick prompt #201276

merged 11 commits into from
Dec 2, 2024
+53 −34

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Nov 21, 2024 •
edited by kibanamachine
Loading

Summary

Builds on a community PR to continue the work to resolve #198630 by removing the legacy ESQL quick prompt.

This PR includes:

  • @kyracho commits that remove the quick prompt from the BASE_SECURITY_QUICK_PROMPTS and prevents it from being created
  • Adds a deleteByQuery in plugin start to delete the "legacy" quick prompt from any prompt data stream it may exist in
    • Moves the legacy title translation to elastic_assistant for delete query

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development Team:Security Generative AI Security Generative AI labels Nov 21, 2024
@stephmilovic stephmilovic requested a review from a team as a code owner November 21, 2024 20:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic stephmilovic mentioned this pull request Nov 21, 2024
Closed
@stephmilovic stephmilovic mentioned this pull request Nov 21, 2024
Closed
2 tasks
@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 14.6MB 14.6MB -2.2KB

History

@stephmilovic stephmilovic merged commit 30ceb1a into elastic:main Dec 2, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12123997304

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
@stephmilovic
[Security solution] Remove legacy ESQL quick prompt (elastic#201276)
be63863 
(cherry picked from commit 30ceb1a)
@kibanamachine kibanamachine mentioned this pull request Dec 2, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
@stephmilovic
[Security solution] Remove legacy ESQL quick prompt (elastic#201276)
293da1e 
(cherry picked from commit 30ceb1a)
@kibanamachine kibanamachine mentioned this pull request Dec 2, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
@stephmilovic
[Security solution] Remove legacy ESQL quick prompt (elastic#201276)
dd61a9f 
(cherry picked from commit 30ceb1a)
@kibanamachine kibanamachine mentioned this pull request Dec 2, 2024
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 8.15 Backport failed because of merge conflicts
✅ 8.16
✅ 8.17
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 201276

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 2, 2024
@kibanamachine @stephmilovic
[8.16] [Security solution] Remove legacy ESQL quick prompt (#201276) (#…
216722b 
…202540)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security solution] Remove legacy ESQL quick prompt
(#201276)](#201276)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T16:47:18Z","message":"[Security
solution] Remove legacy ESQL quick prompt
(#201276)","sha":"30ceb1a0533364e6915bf544827d59cf441bcbf5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-major","Team:Security Generative
AI"],"title":"[Security solution] Remove legacy ESQL quick
prompt","number":201276,"url":"https://github.com/elastic/kibana/pull/201276","mergeCommit":{"message":"[Security
solution] Remove legacy ESQL quick prompt
(#201276)","sha":"30ceb1a0533364e6915bf544827d59cf441bcbf5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201276","number":201276,"mergeCommit":{"message":"[Security
solution] Remove legacy ESQL quick prompt
(#201276)","sha":"30ceb1a0533364e6915bf544827d59cf441bcbf5"}}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 2, 2024
@kibanamachine @stephmilovic
[8.x] [Security solution] Remove legacy ESQL quick prompt (#201276) (#…
8f9c844 
…202542)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Security solution] Remove legacy ESQL quick prompt
(#201276)](#201276)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T16:47:18Z","message":"[Security
solution] Remove legacy ESQL quick prompt
(#201276)","sha":"30ceb1a0533364e6915bf544827d59cf441bcbf5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-major","Team:Security Generative
AI"],"title":"[Security solution] Remove legacy ESQL quick
prompt","number":201276,"url":"https://github.com/elastic/kibana/pull/201276","mergeCommit":{"message":"[Security
solution] Remove legacy ESQL quick prompt
(#201276)","sha":"30ceb1a0533364e6915bf544827d59cf441bcbf5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201276","number":201276,"mergeCommit":{"message":"[Security
solution] Remove legacy ESQL quick prompt
(#201276)","sha":"30ceb1a0533364e6915bf544827d59cf441bcbf5"}}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Dec 2, 2024
Merged
7 tasks
kibanamachine added a commit that referenced this pull request Dec 2, 2024
@kibanamachine @stephmilovic @elasticmachine
[8.17] [Security solution] Remove legacy ESQL quick prompt (#201276) (#…
68721fb 
…202541)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Security solution] Remove legacy ESQL quick prompt
(#201276)](#201276)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T16:47:18Z","message":"[Security
solution] Remove legacy ESQL quick prompt
(#201276)","sha":"30ceb1a0533364e6915bf544827d59cf441bcbf5","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-major","Team:Security Generative
AI"],"title":"[Security solution] Remove legacy ESQL quick
prompt","number":201276,"url":"https://github.com/elastic/kibana/pull/201276","mergeCommit":{"message":"[Security
solution] Remove legacy ESQL quick prompt
(#201276)","sha":"30ceb1a0533364e6915bf544827d59cf441bcbf5"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201276","number":201276,"mergeCommit":{"message":"[Security
solution] Remove legacy ESQL quick prompt
(#201276)","sha":"30ceb1a0533364e6915bf544827d59cf441bcbf5"}}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
@stephmilovic @hop-dev
[Security solution] Remove legacy ESQL quick prompt (elastic#201276)
022f92e
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@stephmilovic @CAWilson94
[Security solution] Remove legacy ESQL quick prompt (elastic#201276)
61c8e35
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@stephmilovic @CAWilson94
[Security solution] Remove legacy ESQL quick prompt (elastic#201276)
df4bcf6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

Assignees
No one assigned
Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development release_note:skip Skip the PR/issue when compiling release notes Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.16.2 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security GenAI][AI Assistant] Remove ES|QL quick prompt, as it is no longer relevant
5 participants
@stephmilovic @elasticmachine @kibanamachine @patrykkopycinski @kyracho