Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security GenAI][AI Assistant] Remove ES|QL quick prompt, as it is no longer relevant #198630

Closed
peluja1012 opened this issue Oct 31, 2024 · 6 comments · Fixed by #201276
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@peluja1012
Copy link
Contributor

Describe the bug:
The ES|QL quick prompt is always displayed in the Security AI Assistant. The original purpose of this prompt was to help users with the intricacies of crafting the right prompt to produce good ES|QL results. With the move to our NaturalLanguageToESQL task, the ES|QL generation process improved and the probability of getting accurate and relevant ES|QL results is much higher. Therefore, we should remove the ES|QL quick prompt.

Kibana/Elasticsearch Stack version:
8.16 BC3

Steps to reproduce:

  1. Navigate to the Security AI Assistant.
  2. Notice that the ES|QL quick prompt appears as an option.

Screenshots (if relevant):
Image
Image

@peluja1012 peluja1012 added bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Security Generative AI Security Generative AI labels Oct 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@kyracho
Copy link
Contributor

kyracho commented Nov 18, 2024

Hi! I'm a relatively new contributor to Kibana. This issue doesn't have a 'good first issue' label, but it seemed manageable, so I opened a PR. It meets the requirements outlined in the issue and doesn't seem to break anything. If someone could please review it and provide some feedback, I'd really appreciate it. thanks!

@kyracho
Copy link
Contributor

kyracho commented Nov 19, 2024

@peluja1012 just checking if you mean removing the ES|QL Query Generation in particular, or removing the entire quick prompt functionality from the AI Assistant?

@stephmilovic
Copy link
Contributor

Hey there @kyracho. I would not say this is a good first issue because it is not as simple as just removing the prompt from being created. We also want to remove any existing occurrences of the prompt from all relevant data streams.

@kyracho
Copy link
Contributor

kyracho commented Nov 19, 2024

@stephmilovic Hi! I’ve removed the quick prompt from the AI assistant, so it’s no longer displayed as an example. From what I understand of the task, any stored data related to the quick prompt shouldn’t cause any issues. If any unit tests or integration tests need to be adjusted, I'd be happy to take care of those as well. When you mentioned 'data streams,' could you please clarify what you meant? I’d really appreciate the opportunity to learn more. Thank you so much!"

@stephmilovic
Copy link
Contributor

Sure, these tags are stored in a data stream called like .kibana-elastic-ai-assistant-prompts-${SpaceName}. Although you've removed them from the creation flow here, if someone had already created it (ie, the user is upgrading from an old version), the quick prompt will continue to appear. For example, this is what I see when I run your branch:

Image

I've pulled your branch, added a couple of commits with deleteByQuery addition, and opened a new PR #201276

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Security Generative AI Security Generative AI Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants