[Inventory] Open in Discover link should use indices from entity definition #200595
Assignees
Labels
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Comments
jennypavlova
added
the
Team:obs-ux-infra_services
jennypavlova
added
needs-team
jennypavlova
changed the title
rmyz
removed
the
needs-refinement
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 28, 2024
…1433) Closes elastic#200595 ## Summary This PR changes the link to discover: - Pass a different data view (using the entity definition indices) - from Open in Discover to Explore in Discover ## Testing - To have the test data I used metricbeat (for the host entity) and synthtrace (for the other entities type) - Open the inventory page and expand an entity type - Click on the `...` in the actions column - Click on `Explore in Discover` The results should be filtered by the selected entity and the dataview should include the indices from the entity definition: https://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a https://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90 With service type filter (should not persist) https://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit afc5e51)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Nov 28, 2024
…1433) Closes elastic#200595 ## Summary This PR changes the link to discover: - Pass a different data view (using the entity definition indices) - from Open in Discover to Explore in Discover ## Testing - To have the test data I used metricbeat (for the host entity) and synthtrace (for the other entities type) - Open the inventory page and expand an entity type - Click on the `...` in the actions column - Click on `Explore in Discover` The results should be filtered by the selected entity and the dataview should include the indices from the entity definition: https://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a https://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90 With service type filter (should not persist) https://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607 --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit afc5e51)
kibanamachine
added a commit
that referenced
this issue
Nov 29, 2024
) (#202154) # Backport This will backport the following commits from `main` to `8.x`: - [[Inventory] Change discover link to use entity definition (#201433)](#201433) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T11:44:20Z","message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","backport:version","v8.17.0"],"title":"[Inventory] Change discover link to use entity definition","number":201433,"url":"https://github.com/elastic/kibana/pull/201433","mergeCommit":{"message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201433","number":201433,"mergeCommit":{"message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: jennypavlova <[email protected]>
kibanamachine
added a commit
that referenced
this issue
Nov 29, 2024
…1433) (#202153) # Backport This will backport the following commits from `main` to `8.17`: - [[Inventory] Change discover link to use entity definition (#201433)](#201433) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-28T11:44:20Z","message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","backport:version","v8.17.0"],"title":"[Inventory] Change discover link to use entity definition","number":201433,"url":"https://github.com/elastic/kibana/pull/201433","mergeCommit":{"message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201433","number":201433,"mergeCommit":{"message":"[Inventory] Change discover link to use entity definition (#201433)\n\nCloses #200595 \r\n\r\n## Summary\r\n\r\nThis PR changes the link to discover: \r\n- Pass a different data view (using the entity definition indices)\r\n- from Open in Discover to Explore in Discover\r\n\r\n## Testing\r\n\r\n- To have the test data I used metricbeat (for the host entity) and\r\nsynthtrace (for the other entities type)\r\n- Open the inventory page and expand an entity type\r\n- Click on the `...` in the actions column\r\n- Click on `Explore in Discover`\r\n\r\nThe results should be filtered by the selected entity and the dataview\r\nshould include the indices from the entity definition:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90\r\n\r\n\r\nWith service type filter (should not persist)\r\n\r\n\r\nhttps://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"afc5e51e296eb499a17ad82de560d20c352cd2a9"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: jennypavlova <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Dec 12, 2024
…1433) Closes elastic#200595 ## Summary This PR changes the link to discover: - Pass a different data view (using the entity definition indices) - from Open in Discover to Explore in Discover ## Testing - To have the test data I used metricbeat (for the host entity) and synthtrace (for the other entities type) - Open the inventory page and expand an entity type - Click on the `...` in the actions column - Click on `Explore in Discover` The results should be filtered by the selected entity and the dataview should include the indices from the entity definition: https://github.com/user-attachments/assets/29bb46b4-719e-4874-b1aa-056ac28d234a https://github.com/user-attachments/assets/36c08b8b-f507-445e-a7b5-8eb1176beb90 With service type filter (should not persist) https://github.com/user-attachments/assets/ae6ef28a-e55a-4a32-9128-802ebea25607 --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
The link to discover should use a separate ad-hoc data view created based on the
indexPatternsdefined in theEntityDefinition( for example ) To get them we can match theentity.definition_idwhich we have in the entity we are trying to link to discover - in this examplebuiltin_services_from_ecs_data. In the discover locator, we pass the data view id (the one we created from the index patterns)AC:
Each entity within Inventory must show an 'Open in Discover' action which will open Discover using the index patterns set by the respective entity definition
No extra log filters will be added to the data view (all
indexPatternsshould be added to the data view)The existing filters added to the inventory should be persisted (and a kuery with filtering by the entity identity field - in the example:- The only filter we will add is the entityIndentifiyngField: value (for exampleservice.name: "serviceName")service.name: "serviceName")Change the wording from 'Open in Discover' to 'Explore in Discover' (comment)
The text was updated successfully, but these errors were encountered: