[Search] Introduce search navigation plugin #200314
Conversation
TattdCodeMonkey
added
release_note:skip
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
|
@elasticmachine merge upstream |
| @@ -1552,6 +1552,8 @@ | |||
| "@kbn/search-indices/*": ["x-pack/plugins/search_indices/*"], | |||
| "@kbn/search-inference-endpoints": ["x-pack/plugins/search_inference_endpoints"], | |||
| "@kbn/search-inference-endpoints/*": ["x-pack/plugins/search_inference_endpoints/*"], | |||
| "@kbn/search-navigation": ["x-pack/plugins/search_solution/search_navigation"], | |||
There was a problem hiding this comment.
Should we name this search instead of search_solution and keep name consistency with the one for packages? x-pack/packages/search
There was a problem hiding this comment.
so I was using observability_solution & observability_solution as the examples for this and search seemed too generic.
There was a problem hiding this comment.
Thats fair. security is the other one. I dont mind either but would be good we keep consistency and rename the other folder in packages (whilst theres only one package)
x-pack/plugins/enterprise_search/public/applications/shared/layout/classic_nav_helpers.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
| { | ||
| "type": "plugin", | ||
| "id": "@kbn/search-navigation", | ||
| "owner": "@elastic/search-kibana", |
There was a problem hiding this comment.
We need to define a group and visibility for the new plugin.
If it's only used from Search solution I suggest
"group": "search",
"visibility": "private",
Is this a follow-up of this discussion?
There was a problem hiding this comment.
Is this a follow-up of this discussion?
Not exactly, this is more architectural work to make it easier for Search team to develop plugins with UIs that are shared between stack and Serverless Elasticsearch.
But this PR does enable us to remove search playground from enterprise_search plugin. Once this merges I will have that PR up which will also introduce a KibanaFeature for searchPlayground that allows it to be disabled independently of the enterprise_search plugin.
There was a problem hiding this comment.
@gsoldevila I added the group & visibility keys.
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
|
|
Starting backport for target branches: 8.x |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit a84122c) # Conflicts: # .github/CODEOWNERS
# Backport This will backport the following commits from `main` to `8.x`: - [[Search] Introduce search navigation plugin (#200314)](#200314) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Rodney Norris","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-22T14:35:49Z","message":"[Search] Introduce search navigation plugin (#200314)","sha":"a84122c4cab5a61002d91631078056ee5d9cdd08","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor","v8.18.0"],"number":200314,"url":"https://github.com/elastic/kibana/pull/200314","mergeCommit":{"message":"[Search] Introduce search navigation plugin (#200314)","sha":"a84122c4cab5a61002d91631078056ee5d9cdd08"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200314","number":200314,"mergeCommit":{"message":"[Search] Introduce search navigation plugin (#200314)","sha":"a84122c4cab5a61002d91631078056ee5d9cdd08"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Rodney Norris <[email protected]>
Summary
This PR introduces the
search_navigationplugin which will be used as a dependency for other search plugins to render the'classic'page side nav when their UIs are used in Stack. This work is a pre-requisite for the Search team to refactor pages out of theenterprise_searchplugin and instead use thesearch_____plugins to render pages and routes for both Serverless and Stack.Additionally this new plugin is nested in the
x-pack/search_solution/folder which is where we will want to start migrating search specific plugins to for better organization and separation.