-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[canvas] disable canvas application when there are no workpads #200203
Conversation
/ci |
/ci |
/ci |
/ci |
/ci |
/ci |
/ci |
1 similar comment
/ci |
@elasticmachine merge upstream |
/ci |
@elasticmachine merge upstream |
/ci |
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! I just added one concern about the docs.
code review and tested Canvas with and without workpads.
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
…ic#200203) Closes elastic#197370 ### Test instructions 1) open new kibana installation 2) verify canvas is not available in menu or application search bar 3) use saved object import to import canvas workpad. Reload browser 4) verify canvas is available in menu and application search bar --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
…ic#200203) Closes elastic#197370 ### Test instructions 1) open new kibana installation 2) verify canvas is not available in menu or application search bar 3) use saved object import to import canvas workpad. Reload browser 4) verify canvas is available in menu and application search bar --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
…ic#200203) Closes elastic#197370 ### Test instructions 1) open new kibana installation 2) verify canvas is not available in menu or application search bar 3) use saved object import to import canvas workpad. Reload browser 4) verify canvas is available in menu and application search bar --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Closes #197370
Test instructions