Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[canvas] disable canvas application when there are no workpads #200203

Merged
merged 14 commits into from
Nov 20, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 14, 2024

Closes #197370

Test instructions

  1. open new kibana installation
  2. verify canvas is not available in menu or application search bar
  3. use saved object import to import canvas workpad. Reload browser
  4. verify canvas is available in menu and application search bar

@nreese
Copy link
Contributor Author

nreese commented Nov 14, 2024

/ci

@nreese nreese added backport:skip This commit does not require backporting v9.0.0 labels Nov 14, 2024
@nreese
Copy link
Contributor Author

nreese commented Nov 14, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 14, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 14, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 14, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 14, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 14, 2024

/ci

1 similar comment
@nreese
Copy link
Contributor Author

nreese commented Nov 15, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 15, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Nov 15, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented Nov 15, 2024

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Nov 15, 2024

/ci

@nreese nreese marked this pull request as ready for review November 15, 2024 21:20
@nreese nreese requested review from a team as code owners November 15, 2024 21:20
@nreese nreese requested a review from a team as a code owner November 15, 2024 21:20
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes labels Nov 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added Feature:Canvas loe:small Small Level of Effort impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Nov 15, 2024
@nickpeihl nickpeihl self-requested a review November 18, 2024 20:04
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I just added one concern about the docs.

code review and tested Canvas with and without workpads.

docs/user/canvas.asciidoc Show resolved Hide resolved
@nreese
Copy link
Contributor Author

nreese commented Nov 18, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.1MB 1.1MB +1.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 14.7KB 14.6KB -167.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 90 94 +4

History

@nreese nreese merged commit eb68fb2 into elastic:main Nov 20, 2024
21 checks passed
TattdCodeMonkey pushed a commit to TattdCodeMonkey/kibana that referenced this pull request Nov 21, 2024
…ic#200203)

Closes elastic#197370

### Test instructions
1) open new kibana installation
2) verify canvas is not available in menu or application search bar
3) use saved object import to import canvas workpad. Reload browser
4) verify canvas is available in menu and application search bar

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Nov 26, 2024
…ic#200203)

Closes elastic#197370

### Test instructions
1) open new kibana installation
2) verify canvas is not available in menu or application search bar
3) use saved object import to import canvas workpad. Reload browser
4) verify canvas is available in menu and application search bar

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…ic#200203)

Closes elastic#197370

### Test instructions
1) open new kibana installation
2) verify canvas is not available in menu or application search bar
3) use saved object import to import canvas workpad. Reload browser
4) verify canvas is available in menu and application search bar

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Canvas impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Canvas spike] Remove Canvas from menus if the user doesn't have any existing Canvas
6 participants