Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Search:Search Applications:Content page]Missing error text for Select searchable indices field #200141

Closed
L1nBra opened this issue Nov 14, 2024 · 1 comment · Fixed by #200736
Closed

[Search:Search Applications:Content page]Missing error text for Select searchable indices field #200141

L1nBra opened this issue Nov 14, 2024 · 1 comment · Fixed by #200736
Assignees
@alexwizp
Labels
defect-level-3 Moderate UX disruption or potentially confusing Project:Accessibility Team:Search WCAG A

Comments

@L1nBra
Copy link

L1nBra commented Nov 14, 2024

Description
Fields which are in error should have error text that for user it should be instantly clear what is the error and how to fix it.

Preconditions
Stateful Search Applications -> Content page is opened.
Search application is added.

Steps to reproduce

1.Using only keyboard Navigate to Add new indices button by pressing Tab key.
2.Press Enter.
3.Navigate to Select searchable indices field.
4.Enter any text (f.e.: test).
5.Press Tab key.
6.Observe Select searchable indices field.

UI elements
Image

Actual Result

  • Field is indicated as in error, but no error text below the field is present.

Expected Result

  • Error text below the field is present (something like: selected searchable index does not exist).

Meta Issue

Kibana Version: 8.17.0-SNAPSHOT

OS: Windows 11 Pro

Browser: Chrome Version 130.0.6723.70 (Official Build) (64-bit)

WCAG or Vendor Guidance (optional)

Related to: https://github.com/elastic/search-team/issues/8256
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the needs-team Issues missing a team label label Nov 14, 2024
@L1nBra L1nBra added WCAG A Team:Search defect-level-3 Moderate UX disruption or potentially confusing labels Nov 14, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Nov 14, 2024
@alexwizp alexwizp self-assigned this Nov 19, 2024
alexwizp added a commit to alexwizp/kibana that referenced this issue Nov 19, 2024
@alexwizp
fix: [Search:Search Applications:Content page]Missing error text for …
92d6e37 
…Select searchable indices field

Closes: elastic#200141 Closes: elastic#199815
@alexwizp alexwizp mentioned this issue Nov 19, 2024
Merged
alexwizp added a commit that referenced this issue Nov 21, 2024
@alexwizp
fix: [Search:Search Applications:Content page]Missing error text for …
0abcf06 
…Select searchable indices field (#200736)

Closes: #200141 
Closes: #199815

### Description
Fields which are in error should have error text that for user it should
be instantly clear what is the error and how to fix it.

### What was changed: 
1. Error handling was added for`
applications/components/indices_select_combobox.tsx` component

### Screen
<img width="806" alt="image"
src="https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1">
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 21, 2024
@alexwizp
fix: [Search:Search Applications:Content page]Missing error text for …
fe2dc8b 
…Select searchable indices field (elastic#200736)

Closes: elastic#200141
Closes: elastic#199815

### Description
Fields which are in error should have error text that for user it should
be instantly clear what is the error and how to fix it.

### What was changed:
1. Error handling was added for`
applications/components/indices_select_combobox.tsx` component

### Screen
<img width="806" alt="image"
src="https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1">

(cherry picked from commit 0abcf06)
kibanamachine added a commit that referenced this issue Nov 21, 2024
@kibanamachine @alexwizp
[8.x] fix: [Search:Search Applications:Content page]Missing error tex…
9fba1fa 
…t for Select searchable indices field (#200736) (#201241)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Search:Search Applications:Content page]Missing error text for
Select searchable indices field
(#200736)](#200736)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-21T16:41:47Z","message":"fix:
[Search:Search Applications:Content page]Missing error text for Select
searchable indices field (#200736)\n\nCloses: #200141 \r\nCloses:
#199815\r\n\r\n### Description\r\nFields which are in error should have
error text that for user it should\r\nbe instantly clear what is the
error and how to fix it.\r\n\r\n### What was changed: \r\n1. Error
handling was added
for`\r\napplications/components/indices_select_combobox.tsx`
component\r\n\r\n### Screen\r\n<img width=\"806\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1\">","sha":"0abcf06a1a28db146e7dac5a748f9a83d10366cd","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix:
[Search:Search Applications:Content page]Missing error text for Select
searchable indices
field","number":200736,"url":"https://github.com/elastic/kibana/pull/200736","mergeCommit":{"message":"fix:
[Search:Search Applications:Content page]Missing error text for Select
searchable indices field (#200736)\n\nCloses: #200141 \r\nCloses:
#199815\r\n\r\n### Description\r\nFields which are in error should have
error text that for user it should\r\nbe instantly clear what is the
error and how to fix it.\r\n\r\n### What was changed: \r\n1. Error
handling was added
for`\r\napplications/components/indices_select_combobox.tsx`
component\r\n\r\n### Screen\r\n<img width=\"806\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1\">","sha":"0abcf06a1a28db146e7dac5a748f9a83d10366cd"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200736","number":200736,"mergeCommit":{"message":"fix:
[Search:Search Applications:Content page]Missing error text for Select
searchable indices field (#200736)\n\nCloses: #200141 \r\nCloses:
#199815\r\n\r\n### Description\r\nFields which are in error should have
error text that for user it should\r\nbe instantly clear what is the
error and how to fix it.\r\n\r\n### What was changed: \r\n1. Error
handling was added
for`\r\napplications/components/indices_select_combobox.tsx`
component\r\n\r\n### Screen\r\n<img width=\"806\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1\">","sha":"0abcf06a1a28db146e7dac5a748f9a83d10366cd"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@alexwizp @paulinashakirova
fix: [Search:Search Applications:Content page]Missing error text for …
dc1f857 
…Select searchable indices field (elastic#200736)

Closes: elastic#200141 
Closes: elastic#199815

### Description
Fields which are in error should have error text that for user it should
be instantly clear what is the error and how to fix it.

### What was changed: 
1. Error handling was added for`
applications/components/indices_select_combobox.tsx` component

### Screen
<img width="806" alt="image"
src="https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1">
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@alexwizp @CAWilson94
fix: [Search:Search Applications:Content page]Missing error text for …
58c7fc8 
…Select searchable indices field (elastic#200736)

Closes: elastic#200141 
Closes: elastic#199815

### Description
Fields which are in error should have error text that for user it should
be instantly clear what is the error and how to fix it.

### What was changed: 
1. Error handling was added for`
applications/components/indices_select_combobox.tsx` component

### Screen
<img width="806" alt="image"
src="https://github.com/user-attachments/assets/54a51822-d66a-4f50-be3f-2d8b203b0cd1">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
defect-level-3 Moderate UX disruption or potentially confusing Project:Accessibility Team:Search WCAG A
Projects
None yet
Milestone
No milestone
3 participants
@elasticmachine @alexwizp @L1nBra