Unskip _shared_links.ts functional test

[kertal]

Summary

Fixes #196627

This is a workaround to unskip this test. The underlying test failure is independent of any code change in this area, it was starting with an upgrade of the chrome functional test driver. It cause the order of error message in the given case to be different, and therefore the test started to fail. This is not a great fix, it just checks for the 2nd toast (there are 3 identical ones here 🙈 , and therefore it's not flaky anymore, but given this is not a bug fix, but a flaky behavior fix for 7.17, I think it can be justified)

It doesn't fail in main, there's a different logic in place, and the issue of having multiple toasts was fixed there

When it fails locally, there are plenty of toasts and if the order is like in the described case, the tests fails. with this fix, it no longer doesn. because the 2nd toast will always contain the right message the tests expects

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[kertal]

/ci

[kibanamachine]

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7341

[✅] OSS CI Group 6: 25/25 tests passed.
[✅] Default CI Group 6: 25/25 tests passed.

see run history

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

[jughosta]

Thanks!

Wonder if it would be better to go through all visible toasts and check if at least one contains the message.

[kertal]

Thanks!

Wonder if it would be better to go through all visible toasts and check if at least one contains the message.

I do agree, and we are using better logic in main, but do you think it's worth the effort in this case (I definitely would be in main, 8.x)

[jughosta]

I am fine with keeping it this way if it works and is stable.

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: c6b4438
• Storybooks Preview

Metrics [docs]

✅ unchanged

History

• 💔 Build #248719 failed 8598f28
• 💚 Build #248453 succeeded d966409

cc @kertal