Reducing vulnerability runtime mappings #198739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opauloh
added
release_note:skip
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
opauloh
commented
Nov 2, 2024
| export const CDR_VULNERABILITY_DATA_TABLE_RUNTIME_MAPPING_FIELDS: string[] = [ | ||
| VULNERABILITY_FIELDS.VENDOR, | ||
| ]; | ||
| export const CDR_VULNERABILITY_DATA_TABLE_RUNTIME_MAPPING_FIELDS: string[] = []; |
There was a problem hiding this comment.
decided to keep the constant while we have the runtime mappings for misconfigurations, so its clear that there's no runtime mappings for vulnerabilities.
maxcold
approved these changes
Nov 4, 2024
|
Starting backport for target branches: 8.16, 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2024
## Summary It closes elastic/security-team#11034 This PR removes runtime mappings for vulnerabilities, since they will be added on the third party integration on [this PR](elastic/integrations#11614) before the 8.16 release, we can remove the runtime mappings in Kibana in favour of not compromising performance. Co-authored-by: Maxim Kholod <[email protected]> (cherry picked from commit 10d7926)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 4, 2024
## Summary It closes elastic/security-team#11034 This PR removes runtime mappings for vulnerabilities, since they will be added on the third party integration on [this PR](elastic/integrations#11614) before the 8.16 release, we can remove the runtime mappings in Kibana in favour of not compromising performance. Co-authored-by: Maxim Kholod <[email protected]> (cherry picked from commit 10d7926)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Reducing vulnerability runtime mappings (#198739)](#198739) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulo Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T14:00:35Z","message":"Reducing vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR removes runtime mappings for vulnerabilities, since they will be\r\nadded on the third party integration on [this\r\nPR](elastic/integrations#11614) before the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","v8.16.0","backport:version","v8.17.0"],"title":"Reducing vulnerability runtime mappings","number":198739,"url":"https://github.com/elastic/kibana/pull/198739","mergeCommit":{"message":"Reducing vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR removes runtime mappings for vulnerabilities, since they will be\r\nadded on the third party integration on [this\r\nPR](elastic/integrations#11614) before the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198739","number":198739,"mergeCommit":{"message":"Reducing vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR removes runtime mappings for vulnerabilities, since they will be\r\nadded on the third party integration on [this\r\nPR](elastic/integrations#11614) before the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Paulo Silva <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 4, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [Reducing vulnerability runtime mappings (#198739)](#198739) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulo Silva","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T14:00:35Z","message":"Reducing vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR removes runtime mappings for vulnerabilities, since they will be\r\nadded on the third party integration on [this\r\nPR](elastic/integrations#11614) before the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Cloud Security","v8.16.0","backport:version","v8.17.0"],"title":"Reducing vulnerability runtime mappings","number":198739,"url":"https://github.com/elastic/kibana/pull/198739","mergeCommit":{"message":"Reducing vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR removes runtime mappings for vulnerabilities, since they will be\r\nadded on the third party integration on [this\r\nPR](elastic/integrations#11614) before the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198739","number":198739,"mergeCommit":{"message":"Reducing vulnerability runtime mappings (#198739)\n\n## Summary\r\n\r\nIt closes https://github.com/elastic/security-team/issues/11034\r\n\r\nThis PR removes runtime mappings for vulnerabilities, since they will be\r\nadded on the third party integration on [this\r\nPR](elastic/integrations#11614) before the 8.16\r\nrelease, we can remove the runtime mappings in Kibana in favour of not\r\ncompromising performance.\r\n\r\nCo-authored-by: Maxim Kholod <[email protected]>","sha":"10d7926e3b2a943250d0ec2437c8d645486b84bd"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Paulo Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes https://github.com/elastic/security-team/issues/11034
This PR removes runtime mappings for vulnerabilities, since they will be added on the third party integration on this PR before the 8.16 release, we can remove the runtime mappings in Kibana in favour of not compromising performance.