-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset Quality] Change logic to identify integrations #198692
[Dataset Quality] Change logic to identify integrations #198692
Conversation
Pinging @elastic/fleet (Team:Fleet) |
@elasticmachine merge upstream |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#7429[✅] x-pack/test_serverless/functional/test_suites/observability/config.ts: 25/25 tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for applying the suggestions I left, in particular the work to optimize the integration retrieval 👏
@elasticmachine merge upstream |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
History
|
Starting backport for target branches: 8.x |
Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Felix Stürmer <[email protected]> (cherry picked from commit 86a0444)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
… (#202565) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset Quality] Change logic to identify integrations (#198692)](#198692) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Achyut Jhunjhunwala","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T18:37:31Z","message":"[Dataset Quality] Change logic to identify integrations (#198692)\n\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Felix Stürmer <[email protected]>","sha":"86a044484d75595ac0d86feb8cd597d3e0e4fee1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs","Feature:Dataset Health"],"title":"[Dataset Quality] Change logic to identify integrations","number":198692,"url":"https://github.com/elastic/kibana/pull/198692","mergeCommit":{"message":"[Dataset Quality] Change logic to identify integrations (#198692)\n\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Felix Stürmer <[email protected]>","sha":"86a044484d75595ac0d86feb8cd597d3e0e4fee1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198692","number":198692,"mergeCommit":{"message":"[Dataset Quality] Change logic to identify integrations (#198692)\n\nCo-authored-by: kibanamachine <[email protected]>\r\nCo-authored-by: Elastic Machine <[email protected]>\r\nCo-authored-by: Felix Stürmer <[email protected]>","sha":"86a044484d75595ac0d86feb8cd597d3e0e4fee1"}}]}] BACKPORT--> Co-authored-by: Achyut Jhunjhunwala <[email protected]>
Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Felix Stürmer <[email protected]>
Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Felix Stürmer <[email protected]>
Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Felix Stürmer <[email protected]>
Summary
What has changed ?
Previously
Integration Name
from the_meta
tag present in ES DataStream Endpoint.This process of getting Integration Name from
_meta
tag was not reliable hence required changeCurrently
integration/check
endpoint. What this endpoint does isGET _data_stream/logs-apm.app.adservice-default
GET _index_template/logs-apm.app@template
The above API still checks for
meta
field for Integration name, if its finds that, it simply returns the Integrations. Else the api would check based on the logic above and then load integration. If its integration, load it and then call the function to load integration dashboards.APM App is not an integration. Its a special package with all assets
What's pending ?
Any Screenshots ?
The
logs-apm.app.*-*
data stream now shows Fix It Flow with option to increase field limit for Users with proper rightsWant to run this locally?
Synthtrace CLI is a bit problematic to generate data for this scenario - #199280
degraded_field_flyout.ts
file,after
block at the endit
withit.only
in the last describe block of this page.