-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test: Serverless Observability Functional Tests.x-pack/test_serverless/functional/test_suites/observability/dataset_quality/degraded_field_flyout·ts - serverless observability UI Dataset Quality Degraded fields flyout testing root cause for ignored fields current field limit issues should let user increase the field limit for integrations #200287
Labels
failed-test
A test failure on a tracked branch, potentially flaky-test
Team:obs-ux-logs
Observability Logs User Experience Team
Comments
kibanamachine
added
the
failed-test
A test failure on a tracked branch, potentially flaky-test
label
Nov 15, 2024
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
I ran the flaky test runner in #198692, which changed the underlying code, and it passed. I think we can reasonable assume that this was either an rare performance problem in the test infrastructure or it was fixed by the PR. |
3 tasks
New failure: kibana-on-merge - main |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Dec 2, 2024
## 📓 Summary Closes elastic#198849 Closes elastic#200287 Closes elastic#201273 Closes elastic#201975 The above issues were raised with similar conditions which converged in the following assumptions: - They are raised due to timeout identifying a visual element on the degraded fields flyout. - They are raised due to a missing UI element, which is part of a common sub-tree conditionally rendered when the data analysis is completed. - They are raised in serverless tests, where the latency might be randomly higher. Given the nature of these tests, which locally always pass correctly given the fastest nature of a local setup, I assume these random failures are due to latency on the common request gating the rendering of these sections. As a fix, I added a wait on the global loading indicator before the assertions, which should wait for the data loading to be completed before running the assertions on the UI elements. Co-authored-by: Marco Antonio Ghiani <[email protected]> (cherry picked from commit d13904e)
kibanamachine
added a commit
that referenced
this issue
Dec 2, 2024
#202432) # Backport This will backport the following commits from `main` to `8.x`: - [[Dataset Quality] Fix tests for degraded fields flyout (#202288)](#202288) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Antonio Ghiani","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T11:04:48Z","message":"[Dataset Quality] Fix tests for degraded fields flyout (#202288)\n\n## 📓 Summary\r\n\r\nCloses #198849 \r\nCloses #200287 \r\nCloses #201273 \r\nCloses #201975 \r\n\r\nThe above issues were raised with similar conditions which converged in\r\nthe following assumptions:\r\n- They are raised due to timeout identifying a visual element on the\r\ndegraded fields flyout.\r\n- They are raised due to a missing UI element, which is part of a common\r\nsub-tree conditionally rendered when the data analysis is completed.\r\n- They are raised in serverless tests, where the latency might be\r\nrandomly higher.\r\n\r\nGiven the nature of these tests, which locally always pass correctly\r\ngiven the fastest nature of a local setup, I assume these random\r\nfailures are due to latency on the common request gating the rendering\r\nof these sections.\r\n\r\nAs a fix, I added a wait on the global loading indicator before the\r\nassertions, which should wait for the data loading to be completed\r\nbefore running the assertions on the UI elements.\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"d13904eb6596edd51e4d52aa74c24c070be3ce5c","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","Team:obs-ux-logs"],"title":"[Dataset Quality] Fix tests for degraded fields flyout","number":202288,"url":"https://github.com/elastic/kibana/pull/202288","mergeCommit":{"message":"[Dataset Quality] Fix tests for degraded fields flyout (#202288)\n\n## 📓 Summary\r\n\r\nCloses #198849 \r\nCloses #200287 \r\nCloses #201273 \r\nCloses #201975 \r\n\r\nThe above issues were raised with similar conditions which converged in\r\nthe following assumptions:\r\n- They are raised due to timeout identifying a visual element on the\r\ndegraded fields flyout.\r\n- They are raised due to a missing UI element, which is part of a common\r\nsub-tree conditionally rendered when the data analysis is completed.\r\n- They are raised in serverless tests, where the latency might be\r\nrandomly higher.\r\n\r\nGiven the nature of these tests, which locally always pass correctly\r\ngiven the fastest nature of a local setup, I assume these random\r\nfailures are due to latency on the common request gating the rendering\r\nof these sections.\r\n\r\nAs a fix, I added a wait on the global loading indicator before the\r\nassertions, which should wait for the data loading to be completed\r\nbefore running the assertions on the UI elements.\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"d13904eb6596edd51e4d52aa74c24c070be3ce5c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202288","number":202288,"mergeCommit":{"message":"[Dataset Quality] Fix tests for degraded fields flyout (#202288)\n\n## 📓 Summary\r\n\r\nCloses #198849 \r\nCloses #200287 \r\nCloses #201273 \r\nCloses #201975 \r\n\r\nThe above issues were raised with similar conditions which converged in\r\nthe following assumptions:\r\n- They are raised due to timeout identifying a visual element on the\r\ndegraded fields flyout.\r\n- They are raised due to a missing UI element, which is part of a common\r\nsub-tree conditionally rendered when the data analysis is completed.\r\n- They are raised in serverless tests, where the latency might be\r\nrandomly higher.\r\n\r\nGiven the nature of these tests, which locally always pass correctly\r\ngiven the fastest nature of a local setup, I assume these random\r\nfailures are due to latency on the common request gating the rendering\r\nof these sections.\r\n\r\nAs a fix, I added a wait on the global loading indicator before the\r\nassertions, which should wait for the data loading to be completed\r\nbefore running the assertions on the UI elements.\r\n\r\nCo-authored-by: Marco Antonio Ghiani <[email protected]>","sha":"d13904eb6596edd51e4d52aa74c24c070be3ce5c"}}]}] BACKPORT--> Co-authored-by: Marco Antonio Ghiani <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Dec 9, 2024
## 📓 Summary Closes elastic#198849 Closes elastic#200287 Closes elastic#201273 Closes elastic#201975 The above issues were raised with similar conditions which converged in the following assumptions: - They are raised due to timeout identifying a visual element on the degraded fields flyout. - They are raised due to a missing UI element, which is part of a common sub-tree conditionally rendered when the data analysis is completed. - They are raised in serverless tests, where the latency might be randomly higher. Given the nature of these tests, which locally always pass correctly given the fastest nature of a local setup, I assume these random failures are due to latency on the common request gating the rendering of these sections. As a fix, I added a wait on the global loading indicator before the assertions, which should wait for the data loading to be completed before running the assertions on the UI elements. Co-authored-by: Marco Antonio Ghiani <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Dec 12, 2024
## 📓 Summary Closes elastic#198849 Closes elastic#200287 Closes elastic#201273 Closes elastic#201975 The above issues were raised with similar conditions which converged in the following assumptions: - They are raised due to timeout identifying a visual element on the degraded fields flyout. - They are raised due to a missing UI element, which is part of a common sub-tree conditionally rendered when the data analysis is completed. - They are raised in serverless tests, where the latency might be randomly higher. Given the nature of these tests, which locally always pass correctly given the fastest nature of a local setup, I assume these random failures are due to latency on the common request gating the rendering of these sections. As a fix, I added a wait on the global loading indicator before the assertions, which should wait for the data loading to be completed before running the assertions on the UI elements. Co-authored-by: Marco Antonio Ghiani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
failed-test
A test failure on a tracked branch, potentially flaky-test
Team:obs-ux-logs
Observability Logs User Experience Team
A test failed on a tracked branch
First failure: kibana-on-merge - main
The text was updated successfully, but these errors were encountered: