Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboards] Export CSV doesnt work #198517

Closed
stratoula opened this issue Oct 31, 2024 · 5 comments · Fixed by #198547
Closed

[Dashboards] Export CSV doesnt work #198517

stratoula opened this issue Oct 31, 2024 · 5 comments · Fixed by #198547
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@stratoula
Copy link
Contributor

stratoula commented Oct 31, 2024 •
edited
Loading

Kibana version:
main, 8.16

Describe the bug:
The download csv action doesnt work as expected in the dashboards

Image

It used to work ok so I am assuming that is due to the embeddables refactoring

Just try to download a CSV for a Lens viz and you will see that it doesnt work and the above error appears in the console.
@stratoula stratoula added the bug Fixes for quality problems that affect the customer experience label Oct 31, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 31, 2024
@stratoula stratoula added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed bug Fixes for quality problems that affect the customer experience labels Oct 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 31, 2024
@stratoula stratoula added the bug Fixes for quality problems that affect the customer experience label Oct 31, 2024
@bhavyarm
Copy link
Contributor

Happening in 8.16.0 BC2.

@nreese
Copy link
Contributor

nreese commented Oct 31, 2024

Looks like its a regression from #193644, which merged into 8.16. I am working on a fix

@nreese nreese self-assigned this Oct 31, 2024
@nreese nreese removed bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Oct 31, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 31, 2024
@nreese nreese added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Oct 31, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 31, 2024
@nreese nreese added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. needs-team Issues missing a team label labels Oct 31, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 31, 2024
@bhavyarm bhavyarm added Team:Visualizations Visualization editors, elastic-charts and infrastructure needs-team Issues missing a team label and removed bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Oct 31, 2024
@nreese nreese added bug Fixes for quality problems that affect the customer experience and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure needs-team Issues missing a team label labels Oct 31, 2024
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Oct 31, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@nreese
Copy link
Contributor

nreese commented Oct 31, 2024 •
edited
Loading

Action is owned by Team:presentation, so removing tag Team:Visualizations

This was referenced Oct 31, 2024
Merged
Merged
nreese added a commit that referenced this issue Oct 31, 2024
@nreese
[Dashboard] fix Export CSV doesnt work (#198547)
0cd2d92 
Closes #198517

#193644 refactored Dashboard
services. Part of this refactor moved `fieldFormats` from
`data.fieldFormats` to getting `fieldFormats` directly from the
fieldFormats plugin. That is because `data.fieldFormats` is marked as
deprecated. The problem is that the fieldFormats plugin was not defined
under `requiredPlugins` and thus was undefined at runtime.

### Test instructions
1) install web logs sample data
2) open web logs sample data dashboard
3) hover over "[Logs] Response Codes Over Time + Annotations" panel and
select "three dots" icon. Then select "Download CSV". Verify there are
no errors in web browser console and CSV is downloaded.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 31, 2024
@nreese
[Dashboard] fix Export CSV doesnt work (elastic#198547)
f5546b4 
Closes elastic#198517

elastic#193644 refactored Dashboard
services. Part of this refactor moved `fieldFormats` from
`data.fieldFormats` to getting `fieldFormats` directly from the
fieldFormats plugin. That is because `data.fieldFormats` is marked as
deprecated. The problem is that the fieldFormats plugin was not defined
under `requiredPlugins` and thus was undefined at runtime.

### Test instructions
1) install web logs sample data
2) open web logs sample data dashboard
3) hover over "[Logs] Response Codes Over Time + Annotations" panel and
select "three dots" icon. Then select "Download CSV". Verify there are
no errors in web browser console and CSV is downloaded.

(cherry picked from commit 0cd2d92)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 31, 2024
@nreese
[Dashboard] fix Export CSV doesnt work (elastic#198547)
c4e482c 
Closes elastic#198517

elastic#193644 refactored Dashboard
services. Part of this refactor moved `fieldFormats` from
`data.fieldFormats` to getting `fieldFormats` directly from the
fieldFormats plugin. That is because `data.fieldFormats` is marked as
deprecated. The problem is that the fieldFormats plugin was not defined
under `requiredPlugins` and thus was undefined at runtime.

### Test instructions
1) install web logs sample data
2) open web logs sample data dashboard
3) hover over "[Logs] Response Codes Over Time + Annotations" panel and
select "three dots" icon. Then select "Download CSV". Verify there are
no errors in web browser console and CSV is downloaded.

(cherry picked from commit 0cd2d92)
nreese added a commit to nreese/kibana that referenced this issue Nov 1, 2024
@nreese
[Dashboard] fix Export CSV doesnt work (elastic#198547)
232c794 
Closes elastic#198517

elastic#193644 refactored Dashboard
services. Part of this refactor moved `fieldFormats` from
`data.fieldFormats` to getting `fieldFormats` directly from the
fieldFormats plugin. That is because `data.fieldFormats` is marked as
deprecated. The problem is that the fieldFormats plugin was not defined
under `requiredPlugins` and thus was undefined at runtime.

### Test instructions
1) install web logs sample data
2) open web logs sample data dashboard
3) hover over "[Logs] Response Codes Over Time + Annotations" panel and
select "three dots" icon. Then select "Download CSV". Verify there are
no errors in web browser console and CSV is downloaded.
nreese added a commit that referenced this issue Nov 18, 2024
@nreese @elasticmachine @kibanamachine
[uiActions] display toast when action.execute throws (#198571)
853b59c 
Follow up to #198517.

This PR updates Ui actions to be more robust and safely handle runtime
errors.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 18, 2024
@nreese
[uiActions] display toast when action.execute throws (elastic#198571)
2cf045f 
Follow up to elastic#198517.

This PR updates Ui actions to be more robust and safely handle runtime
errors.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 853b59c)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@nreese @elasticmachine
@kibanamachine @CAWilson94
[uiActions] display toast when action.execute throws (elastic#198571)
f135d3b 
Follow up to elastic#198517.

This PR updates Ui actions to be more robust and safely handle runtime
errors.

---------

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dashboard] fix Export CSV doesnt work nreese/kibana
4 participants
@nreese @bhavyarm @elasticmachine @stratoula