[Fleet] Remove deprecated epm APIs #198434

nchaulet · 2024-10-30T18:58:21Z

Description

Related to #189746

API removal

Remove GET/POST/DELETE /epm/packages/:pkgkey APIs in favor of GET/POST/DELETE /epm/packages/:pkgName/:pkgVersion
I add to change the route patterns to support an optionnal {pkgVersion}

Parameter and response change

Remove experimental query parameter in GET /epm/packages and GET /epm/categories
Remove response in response in * /epm/packages* and GET /epm/categories
Remove savedObject in /epm/packages response in favor of installationInfo

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --update'

…let/kibana into feature-remove-deprecated-epm-apis

…deprecated-epm-apis

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --update'

…let/kibana into feature-remove-deprecated-epm-apis

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/fleet --update'

…deprecated-epm-apis

elasticmachine · 2024-11-04T13:10:00Z

Pinging @elastic/fleet (Team:Fleet)

…let/kibana into feature-remove-deprecated-epm-apis

juliaElastic · 2024-11-04T13:28:06Z

x-pack/plugins/fleet/common/types/models/epm.ts

@@ -531,8 +531,8 @@ export type PackageList = PackageListItem[];
 export type PackageListItem = Installable<RegistrySearchResult> & {
  id: string;
  integration?: string;
-  installationInfo?: InstallationInfo;
  savedObject?: InstallableSavedObject;


is savedObject still needed in PackageListItem type?

Yes it still needed that interface is used to type the package server side, and we only populate installationInfo in the handler for public usage.

juliaElastic

LGTM

…deprecated-epm-apis

peteharverson

ML functional test file changes LGTM

ashokaditya · 2024-11-05T12:13:38Z

x-pack/test/fleet_api_integration/apis/package_policy/update.ts

@@ -28,9 +28,9 @@ export default function (providerContext: FtrProviderContext) {
    expect(sortBy(arr1, 'id')).to.eql(sortBy(arr2, 'id'));
  };

-  const getInstallationSavedObject = async (name: string, version: string) => {
+  const getInstallationInfo = async (name: string, version: string) => {


Q: why is this different from the identically named function in helper.ts that takes more params?

Looks like I could use the function from the helper here too, I will do the change

Yeah, I was thinking the same. Thanks 👍🏼

…deprecated-epm-apis

elasticmachine · 2024-11-05T22:55:46Z

💚 Build Succeeded

Buildkite Build
Commit: 3998d5d

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`fleet`	1303	1295	-8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1.7MB	1.7MB	-6.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`fleet`	173.0KB	173.1KB	+162.0B

Unknown metric groups

API count

id	before	after	diff
`fleet`	1426	1418	-8

History

💚 Build #248113 succeeded b40a8ab
💔 Build #248039 failed 4e0c8de
💔 Build #247853 failed 447e599
💔 Build #247851 failed e7a8d2b
💔 Build #247839 failed 4e0771c
💔 Build #247821 failed c0206e0

ashokaditya

Thanks for the changes 🚀

xcrzx

Rules Management test changes LGTM 👍

nchaulet force-pushed the feature-remove-deprecated-epm-apis branch 2 times, most recently from 78cb626 to f742465 Compare October 31, 2024 14:42

[Fleet] Remove deprecated epm APIs

27c3f48

nchaulet force-pushed the feature-remove-deprecated-epm-apis branch from f742465 to 27c3f48 Compare October 31, 2024 15:11

nchaulet added 3 commits October 31, 2024 11:43

fix types

ea89b50

remove experimental from GET /epm/categories

e36f1f8

fix tests

ac9b09c

nchaulet force-pushed the feature-remove-deprecated-epm-apis branch from f08fcd0 to ac9b09c Compare October 31, 2024 17:33

kibanamachine and others added 4 commits October 31, 2024 18:09

fix test

1ebe34e

Merge branch 'feature-remove-deprecated-epm-apis' of github.com:nchau…

92e3c15

…let/kibana into feature-remove-deprecated-epm-apis

fix tests

98eae36

nchaulet mentioned this pull request Oct 31, 2024

[Fleet] Remove deprecated APIs, parameters, and response properties from Fleet API #189746

Closed

nchaulet added 2 commits November 1, 2024 08:01

remove response from categories endpoint

68c57bf

Merge branch 'main' of github.com:elastic/kibana into feature-remove-…

72ee474

…deprecated-epm-apis

nchaulet force-pushed the feature-remove-deprecated-epm-apis branch from 80ebee6 to 72ee474 Compare November 1, 2024 12:03

nchaulet and others added 9 commits November 1, 2024 09:48

remove response and experimental parameter

daae4d0

fix types

bf961e8

add more tests

557bb51

Merge branch 'feature-remove-deprecated-epm-apis' of github.com:nchau…

ee9854b

…let/kibana into feature-remove-deprecated-epm-apis

[CI] Auto-commit changed files from 'make api-docs'

a920902

fix tests

dc73119

remove more deprecated response body

b5d439c

fix typo

c0206e0

nchaulet added release_note:breaking backport:skip This commit does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 1, 2024

nchaulet and others added 2 commits November 1, 2024 15:44

remove body for delete package apis

4e0771c

Merge branch 'main' of github.com:elastic/kibana into feature-remove-…

df898cb

…deprecated-epm-apis

nchaulet marked this pull request as ready for review November 4, 2024 13:09

nchaulet requested review from a team as code owners November 4, 2024 13:09

nchaulet requested review from ashokaditya, parkiino and jpdjere November 4, 2024 13:09

Merge branch 'feature-remove-deprecated-epm-apis' of github.com:nchau…

4e0c8de

…let/kibana into feature-remove-deprecated-epm-apis

juliaElastic reviewed Nov 4, 2024

View reviewed changes

juliaElastic approved these changes Nov 4, 2024

View reviewed changes

nchaulet mentioned this pull request Nov 4, 2024

[Fleet] remove deprecated settings API endpoints #198799

Merged

nchaulet added 3 commits November 4, 2024 09:50

Merge branch 'main' of github.com:elastic/kibana into feature-remove-…

25bb32b

…deprecated-epm-apis

fix tests

0a0caeb

fix more tests

b40a8ab

peteharverson approved these changes Nov 4, 2024

View reviewed changes

ashokaditya approved these changes Nov 5, 2024

View reviewed changes

banderror requested review from xcrzx and removed request for jpdjere November 5, 2024 18:10

nchaulet added 2 commits November 5, 2024 16:07

fix after review

ce150a3

Merge branch 'main' of github.com:elastic/kibana into feature-remove-…

3998d5d

…deprecated-epm-apis

ashokaditya approved these changes Nov 6, 2024

View reviewed changes

xcrzx approved these changes Nov 6, 2024

View reviewed changes

nchaulet merged commit 15c1ceb into elastic:main Nov 6, 2024
46 checks passed

kibanamachine added the v9.0.0 label Nov 6, 2024

mgadewoll pushed a commit to mgadewoll/kibana that referenced this pull request Nov 7, 2024

[Fleet] Remove deprecated epm APIs (elastic#198434)

c739e11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fleet] Remove deprecated epm APIs #198434

[Fleet] Remove deprecated epm APIs #198434

nchaulet commented Oct 30, 2024 •

edited

Loading

elasticmachine commented Nov 4, 2024

juliaElastic Nov 4, 2024

nchaulet Nov 4, 2024

juliaElastic left a comment

peteharverson left a comment

ashokaditya Nov 5, 2024

nchaulet Nov 5, 2024

ashokaditya Nov 5, 2024

elasticmachine commented Nov 5, 2024

API count

ashokaditya left a comment

xcrzx left a comment

[Fleet] Remove deprecated epm APIs #198434

[Fleet] Remove deprecated epm APIs #198434

Conversation

nchaulet commented Oct 30, 2024 • edited Loading

Description

API removal

Parameter and response change

elasticmachine commented Nov 4, 2024

juliaElastic Nov 4, 2024

Choose a reason for hiding this comment

nchaulet Nov 4, 2024

Choose a reason for hiding this comment

juliaElastic left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

ashokaditya Nov 5, 2024

Choose a reason for hiding this comment

nchaulet Nov 5, 2024

Choose a reason for hiding this comment

ashokaditya Nov 5, 2024

Choose a reason for hiding this comment

elasticmachine commented Nov 5, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

History

ashokaditya left a comment

Choose a reason for hiding this comment

xcrzx left a comment

Choose a reason for hiding this comment

nchaulet commented Oct 30, 2024 •

edited

Loading