Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Rules] Remove the RuleFormV2 from plugins that do not need it #196704

Open
Tracked by #196235
adcoelho opened this issue Oct 17, 2024 · 1 comment
Open
Tracked by #196235

[ResponseOps][Rules] Remove the RuleFormV2 from plugins that do not need it #196704

adcoelho opened this issue Oct 17, 2024 · 1 comment
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@adcoelho
Copy link
Contributor

adcoelho commented Oct 17, 2024 •
edited
Loading

Description

In a previous PR (#196507) the ruleFormV2 feature flag was deprecated in the triggers_actions_ui plugin because it had been renamed without any fallback.

Searching the Kibana codebase for ruleFormV2 yields many results showing that this feature flag is still configurable in a few different plugins. However, although this flag can be set, it doesn't seem to be used for anything in these plugins.

We should remove/deprecate it wherever it is not used at all.

The feature flag was initially introduced in this PR. This might help to find the right places to change it.
@adcoelho adcoelho added Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture labels Oct 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@adcoelho adcoelho mentioned this issue Oct 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adcoelho @elasticmachine