-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inventory][infra] Asset details shows blank metrics section for containers detected by EEM but without integrations data #196553
Comments
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
cc: @roshan-elastic |
Hey @crespocarlos - thanks for this. Could you remind me which containers this happens to? i.e. in what scenario is a container found but no metrics are observed? If these containers will show and be accessed when the @smith - Curious what your thoughts here are? |
It's ok to show the empty session if we're showing a callout telling them they need to add metric data. Shouldn't this be the case for something without integrations data? |
I wonder if the page should show an onboarding flow in these cases or inform why the metrics section is empty. For host, the page renders empty charts, which is not the case here.
EEM, for sure, but it's possible that a container listed in the service overview doesn't have metrics, which could cause this. I can't say if this scenario occurs very often. |
Cool. For containers which only show when EEM is enabled, I'm not too worried about the UX here right now. If we show the call to action as per this issue - that's good enough for now. If this happens for containers without EEM then presumably they've been seeing blank metrics for a while? I don't think solving that is a priority right now.
This issue should show the call out for adding metrics?
Good point. @crespocarlos - shouldn't this issue show the callout if metrics are missing and solve our problem here? |
Ideally, yes, but that doesn't seem to be working for containers. |
Ah - I see. It sounds like we need a bug to follow up on https://github.com/elastic/observability-dev/issues/3966 as it's not meeting the AC. Would you mind creating one if you've been able to replicate? I can prioritise accordingly. |
@roshan-elastic, we can use this ticket to work on the problem. |
@crespocarlos - oh yeah, duh! I'll prioritise - good that we've captured here. Thanks! |
Hi, I'll be taking care of this! I have some comments on this @crespocarlos and @roshan-elastic. About the Metrics tab not showing the callout, I think there might have been a slight misalignment from this comment. The callout is intentionally hidden for anything that's not Docker or Kubernetes. If I understand correctly, the goal of this issue is to display the callout regardless of the container type, is that right? Would it make sense considering we were not even showing the metrics charts/empty states? I might be missing some context here, but it seems that if we’re not even showing the charts, it’s because these types of containers can’t have metrics at all. In that case, what would be the point of prompting users to add metrics if it’s not actually possible? |
After discussing all possible cases privately with @crespocarlos and confirming that everything is covered, the final solution will be, as previously mentioned, to always display the callout whenever metrics are not detected, both on the overview and in the metrics tab. Additionally, the onboarding link will be updated. |
…ics (elastic#202220) ## Summary Closes elastic#196553. In this PR, we removed the restriction that prevented the "Add metrics" callout from appearing on containers that aren't Docker or Kubernetes, even if they didn’t have metrics. Previously, this was done to only show the callout on Docker/Kubernetes containers with available metrics. Now, the callout will be displayed for all containers lacking metrics, ensuring a more consistent user experience across different container types, regardless of the underlying technology. |View|Before|After| |-|-|-| |Overview|![Screenshot 2024-11-29 at 13 35 23](https://github.com/user-attachments/assets/b3d916e6-ee2b-4f1f-8d93-90c8ae595ac1)|![Screenshot 2024-11-29 at 13 33 15](https://github.com/user-attachments/assets/23bb44cf-41bc-4274-b204-8a3c9ceecea5)| |Metrics|![Screenshot 2024-11-29 at 13 35 30](https://github.com/user-attachments/assets/3fbfb81e-d61c-4f28-b9a4-55b8009df8e1)|![Screenshot 2024-11-29 at 13 33 09](https://github.com/user-attachments/assets/1fb48b2f-457e-4453-8758-41f3ceadf794)| The PR also addresses an issue with the onboarding link used in the callout, where the `url` parameter was not properly preselecting any options. |Before|After| |-|-| |![Screen Recording 2024-11-29 at 13 37 05](https://github.com/user-attachments/assets/37f04535-ba4a-428b-b988-2ac4d5c0449a)|![Screen Recording 2024-11-29 at 13 33 26](https://github.com/user-attachments/assets/b52b5b55-a387-40c8-80cd-54aedc9acfc7)| (cherry picked from commit 1b1c415)
…ics (elastic#202220) ## Summary Closes elastic#196553. In this PR, we removed the restriction that prevented the "Add metrics" callout from appearing on containers that aren't Docker or Kubernetes, even if they didn’t have metrics. Previously, this was done to only show the callout on Docker/Kubernetes containers with available metrics. Now, the callout will be displayed for all containers lacking metrics, ensuring a more consistent user experience across different container types, regardless of the underlying technology. |View|Before|After| |-|-|-| |Overview|![Screenshot 2024-11-29 at 13 35 23](https://github.com/user-attachments/assets/b3d916e6-ee2b-4f1f-8d93-90c8ae595ac1)|![Screenshot 2024-11-29 at 13 33 15](https://github.com/user-attachments/assets/23bb44cf-41bc-4274-b204-8a3c9ceecea5)| |Metrics|![Screenshot 2024-11-29 at 13 35 30](https://github.com/user-attachments/assets/3fbfb81e-d61c-4f28-b9a4-55b8009df8e1)|![Screenshot 2024-11-29 at 13 33 09](https://github.com/user-attachments/assets/1fb48b2f-457e-4453-8758-41f3ceadf794)| The PR also addresses an issue with the onboarding link used in the callout, where the `url` parameter was not properly preselecting any options. |Before|After| |-|-| |![Screen Recording 2024-11-29 at 13 37 05](https://github.com/user-attachments/assets/37f04535-ba4a-428b-b988-2ac4d5c0449a)|![Screen Recording 2024-11-29 at 13 33 26](https://github.com/user-attachments/assets/b52b5b55-a387-40c8-80cd-54aedc9acfc7)|
…ics (elastic#202220) ## Summary Closes elastic#196553. In this PR, we removed the restriction that prevented the "Add metrics" callout from appearing on containers that aren't Docker or Kubernetes, even if they didn’t have metrics. Previously, this was done to only show the callout on Docker/Kubernetes containers with available metrics. Now, the callout will be displayed for all containers lacking metrics, ensuring a more consistent user experience across different container types, regardless of the underlying technology. |View|Before|After| |-|-|-| |Overview|![Screenshot 2024-11-29 at 13 35 23](https://github.com/user-attachments/assets/b3d916e6-ee2b-4f1f-8d93-90c8ae595ac1)|![Screenshot 2024-11-29 at 13 33 15](https://github.com/user-attachments/assets/23bb44cf-41bc-4274-b204-8a3c9ceecea5)| |Metrics|![Screenshot 2024-11-29 at 13 35 30](https://github.com/user-attachments/assets/3fbfb81e-d61c-4f28-b9a4-55b8009df8e1)|![Screenshot 2024-11-29 at 13 33 09](https://github.com/user-attachments/assets/1fb48b2f-457e-4453-8758-41f3ceadf794)| The PR also addresses an issue with the onboarding link used in the callout, where the `url` parameter was not properly preselecting any options. |Before|After| |-|-| |![Screen Recording 2024-11-29 at 13 37 05](https://github.com/user-attachments/assets/37f04535-ba4a-428b-b988-2ac4d5c0449a)|![Screen Recording 2024-11-29 at 13 33 26](https://github.com/user-attachments/assets/b52b5b55-a387-40c8-80cd-54aedc9acfc7)|
Summary
The Asset details page is unable to show the metrics section for non-monitored containers. This causes the metrics section and the metrics tab to just show an empty section.
It could perhaps hide the metrics section and tab or display a callout with an onboarding flow.
How to reproduce
AC
The text was updated successfully, but these errors were encountered: