Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inventory][infra] Asset details shows blank metrics section for containers detected by EEM but without integrations data #196553

Closed
crespocarlos opened this issue Oct 16, 2024 · 13 comments · Fixed by #202220
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@crespocarlos
Copy link
Contributor

crespocarlos commented Oct 16, 2024

Summary

The Asset details page is unable to show the metrics section for non-monitored containers. This causes the metrics section and the metrics tab to just show an empty section.

Image

Image

Image

It could perhaps hide the metrics section and tab or display a callout with an onboarding flow.

How to reproduce

  • Start the opentelementry-demo
  • From the Inventory, navigate to the Asset Details from any container

AC

@crespocarlos crespocarlos added needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@crespocarlos crespocarlos self-assigned this Oct 16, 2024
@smith smith added the enhancement New value added to drive a business result label Oct 17, 2024
@crespocarlos crespocarlos changed the title [Inventory] Asset Details to properly handle otel k8s container [Inventory] List K8s containers Oct 17, 2024
@crespocarlos crespocarlos changed the title [Inventory] List K8s containers [Inventory] Asset details to handle containers detected by EEM but without metrics Oct 21, 2024
@crespocarlos crespocarlos changed the title [Inventory] Asset details to handle containers detected by EEM but without metrics [Inventory] Asset details show blank metrics section for containers detected by EEM but without integrations data Oct 21, 2024
@crespocarlos
Copy link
Contributor Author

cc: @roshan-elastic

@crespocarlos crespocarlos changed the title [Inventory] Asset details show blank metrics section for containers detected by EEM but without integrations data [Inventory] Asset details shows blank metrics section for containers detected by EEM but without integrations data Oct 21, 2024
@crespocarlos crespocarlos removed their assignment Oct 21, 2024
@roshan-elastic
Copy link

Hey @crespocarlos - thanks for this.

Could you remind me which containers this happens to?

i.e. in what scenario is a container found but no metrics are observed?

If these containers will show and be accessed when the entityCentricExperience flag is on, I think we can put this as something to tackle later when we want to start polishing things up as we work on entity views.

@smith - Curious what your thoughts here are?

@smith smith added bug Fixes for quality problems that affect the customer experience and removed enhancement New value added to drive a business result labels Oct 22, 2024
@smith
Copy link
Contributor

smith commented Oct 22, 2024

It's ok to show the empty session if we're showing a callout telling them they need to add metric data. Shouldn't this be the case for something without integrations data?

@crespocarlos
Copy link
Contributor Author

I wonder if the page should show an onboarding flow in these cases or inform why the metrics section is empty. For host, the page renders empty charts, which is not the case here.

Could you remind me which containers this happens to?

i.e. in what scenario is a container found but no metrics are observed?

EEM, for sure, but it's possible that a container listed in the service overview doesn't have metrics, which could cause this. I can't say if this scenario occurs very often.

@roshan-elastic
Copy link

EEM, for sure, but it's possible that a container listed in the service overview doesn't have metrics, which could cause this. I can't say if this scenario occurs very often.

Cool. For containers which only show when EEM is enabled, I'm not too worried about the UX here right now. If we show the call to action as per this issue - that's good enough for now.

If this happens for containers without EEM then presumably they've been seeing blank metrics for a while? I don't think solving that is a priority right now.

I wonder if the page should show an onboarding flow in these cases or inform why the metrics section is empty. For host, the page renders empty charts, which is not the case here.

This issue should show the call out for adding metrics?

Shouldn't this be the case for something without integrations data?

Good point. @crespocarlos - shouldn't this issue show the callout if metrics are missing and solve our problem here?

@crespocarlos
Copy link
Contributor Author

@roshan-elastic

Good point. @crespocarlos - shouldn't https://github.com/elastic/observability-dev/issues/3966 show the callout if metrics are missing and solve our problem here?

Ideally, yes, but that doesn't seem to be working for containers.

@roshan-elastic
Copy link

Ah - I see. It sounds like we need a bug to follow up on https://github.com/elastic/observability-dev/issues/3966 as it's not meeting the AC.

Would you mind creating one if you've been able to replicate?

I can prioritise accordingly.

@crespocarlos
Copy link
Contributor Author

@roshan-elastic, we can use this ticket to work on the problem.

@roshan-elastic
Copy link

@crespocarlos - oh yeah, duh!

I'll prioritise - good that we've captured here. Thanks!

@crespocarlos crespocarlos changed the title [Inventory] Asset details shows blank metrics section for containers detected by EEM but without integrations data [Inventory][infra] Asset details shows blank metrics section for containers detected by EEM but without integrations data Nov 26, 2024
@crespocarlos crespocarlos removed the needs-refinement A reason and acceptance criteria need to be defined for this issue label Nov 26, 2024
@iblancof iblancof self-assigned this Nov 28, 2024
@iblancof
Copy link
Contributor

Hi, I'll be taking care of this!

I have some comments on this @crespocarlos and @roshan-elastic.

About the Metrics tab not showing the callout, I think there might have been a slight misalignment from this comment.

The callout is intentionally hidden for anything that's not Docker or Kubernetes.
In fact, the Metrics tab is not even showing the metrics charts/empty states:

If I understand correctly, the goal of this issue is to display the callout regardless of the container type, is that right? Would it make sense considering we were not even showing the metrics charts/empty states?

I might be missing some context here, but it seems that if we’re not even showing the charts, it’s because these types of containers can’t have metrics at all. In that case, what would be the point of prompting users to add metrics if it’s not actually possible?

@crespocarlos
Copy link
Contributor Author

crespocarlos commented Nov 28, 2024

Hey @iblancof

The problem is that without signals data, we don't know whether the entity is a Docker or Kubernetes container. We want to show the callout in this case, as we know that the entity is a container because it has a container.id field

The metrics tab will be hidden as part of #201752

@iblancof
Copy link
Contributor

After discussing all possible cases privately with @crespocarlos and confirming that everything is covered, the final solution will be, as previously mentioned, to always display the callout whenever metrics are not detected, both on the overview and in the metrics tab.

Additionally, the onboarding link will be updated.
Some recent changes from the onboarding team seem to have affected how the current link works, so we’ll adjust it to ensure everything works as expected.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 2, 2024
…ics (elastic#202220)

## Summary

Closes elastic#196553.

In this PR, we removed the restriction that prevented the "Add metrics"
callout from appearing on containers that aren't Docker or Kubernetes,
even if they didn’t have metrics.

Previously, this was done to only show the callout on Docker/Kubernetes
containers with available metrics. Now, the callout will be displayed
for all containers lacking metrics, ensuring a more consistent user
experience across different container types, regardless of the
underlying technology.

|View|Before|After|
|-|-|-|
|Overview|![Screenshot 2024-11-29 at 13 35
23](https://github.com/user-attachments/assets/b3d916e6-ee2b-4f1f-8d93-90c8ae595ac1)|![Screenshot
2024-11-29 at 13 33
15](https://github.com/user-attachments/assets/23bb44cf-41bc-4274-b204-8a3c9ceecea5)|
|Metrics|![Screenshot 2024-11-29 at 13 35
30](https://github.com/user-attachments/assets/3fbfb81e-d61c-4f28-b9a4-55b8009df8e1)|![Screenshot
2024-11-29 at 13 33
09](https://github.com/user-attachments/assets/1fb48b2f-457e-4453-8758-41f3ceadf794)|

The PR also addresses an issue with the onboarding link used in the
callout, where the `url` parameter was not properly preselecting any
options.
|Before|After|
|-|-|
|![Screen Recording 2024-11-29 at 13 37
05](https://github.com/user-attachments/assets/37f04535-ba4a-428b-b988-2ac4d5c0449a)|![Screen
Recording 2024-11-29 at 13 33
26](https://github.com/user-attachments/assets/b52b5b55-a387-40c8-80cd-54aedc9acfc7)|

(cherry picked from commit 1b1c415)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
…ics (elastic#202220)

## Summary

Closes elastic#196553.

In this PR, we removed the restriction that prevented the "Add metrics"
callout from appearing on containers that aren't Docker or Kubernetes,
even if they didn’t have metrics.

Previously, this was done to only show the callout on Docker/Kubernetes
containers with available metrics. Now, the callout will be displayed
for all containers lacking metrics, ensuring a more consistent user
experience across different container types, regardless of the
underlying technology.


|View|Before|After|
|-|-|-|
|Overview|![Screenshot 2024-11-29 at 13 35
23](https://github.com/user-attachments/assets/b3d916e6-ee2b-4f1f-8d93-90c8ae595ac1)|![Screenshot
2024-11-29 at 13 33
15](https://github.com/user-attachments/assets/23bb44cf-41bc-4274-b204-8a3c9ceecea5)|
|Metrics|![Screenshot 2024-11-29 at 13 35
30](https://github.com/user-attachments/assets/3fbfb81e-d61c-4f28-b9a4-55b8009df8e1)|![Screenshot
2024-11-29 at 13 33
09](https://github.com/user-attachments/assets/1fb48b2f-457e-4453-8758-41f3ceadf794)|

The PR also addresses an issue with the onboarding link used in the
callout, where the `url` parameter was not properly preselecting any
options.
|Before|After|
|-|-|
|![Screen Recording 2024-11-29 at 13 37
05](https://github.com/user-attachments/assets/37f04535-ba4a-428b-b988-2ac4d5c0449a)|![Screen
Recording 2024-11-29 at 13 33
26](https://github.com/user-attachments/assets/b52b5b55-a387-40c8-80cd-54aedc9acfc7)|
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
…ics (elastic#202220)

## Summary

Closes elastic#196553.

In this PR, we removed the restriction that prevented the "Add metrics"
callout from appearing on containers that aren't Docker or Kubernetes,
even if they didn’t have metrics.

Previously, this was done to only show the callout on Docker/Kubernetes
containers with available metrics. Now, the callout will be displayed
for all containers lacking metrics, ensuring a more consistent user
experience across different container types, regardless of the
underlying technology.


|View|Before|After|
|-|-|-|
|Overview|![Screenshot 2024-11-29 at 13 35
23](https://github.com/user-attachments/assets/b3d916e6-ee2b-4f1f-8d93-90c8ae595ac1)|![Screenshot
2024-11-29 at 13 33
15](https://github.com/user-attachments/assets/23bb44cf-41bc-4274-b204-8a3c9ceecea5)|
|Metrics|![Screenshot 2024-11-29 at 13 35
30](https://github.com/user-attachments/assets/3fbfb81e-d61c-4f28-b9a4-55b8009df8e1)|![Screenshot
2024-11-29 at 13 33
09](https://github.com/user-attachments/assets/1fb48b2f-457e-4453-8758-41f3ceadf794)|

The PR also addresses an issue with the onboarding link used in the
callout, where the `url` parameter was not properly preselecting any
options.
|Before|After|
|-|-|
|![Screen Recording 2024-11-29 at 13 37
05](https://github.com/user-attachments/assets/37f04535-ba4a-428b-b988-2ac4d5c0449a)|![Screen
Recording 2024-11-29 at 13 33
26](https://github.com/user-attachments/assets/b52b5b55-a387-40c8-80cd-54aedc9acfc7)|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants