Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset Quality] 🐞 Link to logs explorer is broken in non-observability instances #196506

Closed
yngrdyn opened this issue Oct 16, 2024 · 1 comment · Fixed by #197020
Closed

[Dataset Quality] 🐞 Link to logs explorer is broken in non-observability instances #196506

yngrdyn opened this issue Oct 16, 2024 · 1 comment · Fixed by #197020
Assignees
@awahab07
Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team

Comments

@yngrdyn
Copy link
Contributor

yngrdyn commented Oct 16, 2024

📝 Summary

With the introduction of solution based new nav some issues has been detected in dataset quality, specially around cross-linking with Los explorer. When a user is in a security based solution the page still references Logs explorer even when it's not available for the space or the user.

Screen.Recording.2024-10-15.at.12.09.44.mov

✔️ Acceptance Criteria

  • Links to Logs explorer should be replaced by links to Discover whenever Logs explorer is not available.

💡 Implementation hints

  • Dataset quality page is the one in charge of checking whether the application is available or not instead or solely rely on the existence of Logs explorer locator.
@yngrdyn yngrdyn added Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team labels Oct 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@awahab07 awahab07 mentioned this issue Oct 21, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 22, 2024
@awahab07
[Dataset Quality] Check if Obs Logs Explorer accessible before linkin…
059acf6 
…g Logs Explorer (elastic#197020)

Fixes elastic#196506

## Summary

Before linking to Logs Explorer in Dataset Quality, the PR checks if
`observability-logs-explorer` is available and accessible before
consuming the `SINGLE_DATASET_LOCATOR_ID` locator.

Observability Logs Explorer app is not available in Security and Search
solution views.

After the fix:

https://github.com/user-attachments/assets/ed36806a-0483-4765-a6f1-85936b92d390

There's only one more place, Observability Onboarding, where
`SINGLE_DATASET_LOCATOR_ID` is consumed. Which being part of
Observability solution view, it can be assumed that Observability Logs
Explorer will always be available.

![image](https://github.com/user-attachments/assets/b51bf9b6-a9c4-4fd4-8865-3dda76262a93)

----

The other Observability Logs Explorer locator `ALL_DATASETS_LOCATOR_ID`
is only consumed in observability wrapper apps and `apm` and `infra`
plugins, all of which are only available under Observability where
Observability Logs Explorer is also available.

https://github.com/elastic/kibana/blob/68b3267ca2f76d8de4fedef622608d8685e7eceb/packages/deeplinks/observability/locators/observability_logs_explorer.ts#L24

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit c076b7a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@awahab07 awahab07

Labels
Feature:Dataset Health Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dataset Quality] Check if Obs Logs Explorer accessible before linking Logs Explorer awahab07/kibana
3 participants
@yngrdyn @awahab07 @elasticmachine