Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Rules] Deprecate the RuleFormV2 feature flag #196493

Closed
Tracked by #196235
adcoelho opened this issue Oct 16, 2024 · 1 comment · Fixed by #196507
Closed
Tracked by #196235

[ResponseOps][Rules] Deprecate the RuleFormV2 feature flag #196493

adcoelho opened this issue Oct 16, 2024 · 1 comment · Fixed by #196507
Assignees
@adcoelho
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@adcoelho
Copy link
Contributor

Description

In the Rule Form V2 PR the feature flag RuleFormV2 was renamed to isUsingRuleCreateFlyout. This is not the recommended approach because if users have discovered and adopted the config Kibana will fail to start with the following error:

[2024-10-16T09:31:55.792+02:00][FATAL][root] Reason: [config validation of [xpack.trigger_actions_ui].enableExperimental]: [ruleFormV2] is not allowed. Allowed values are: rulesListDatagrid, stackAlertsPage, ruleTagFilter, ruleStatusFilter, rulesDetailLogs, ruleUseExecutionStatus, ruleKqlBar, isMustacheAutocompleteOn, showMustacheAutocompleteSwitch, isUsingRuleCreateFlyout

Since we no longer need the specific flag we should mark it as unused so Kibana can still start up if it sees the config.

This is the relevant code.
@adcoelho adcoelho added bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@adcoelho adcoelho self-assigned this Oct 16, 2024
@cnasikas cnasikas mentioned this issue Oct 16, 2024
Open
@adcoelho adcoelho mentioned this issue Oct 16, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 17, 2024
@adcoelho
[ResponseOps][Rules]Deprecate ruleFormV2 flag. (elastic#196507)
9500dad 
Fixes elastic#196493

## Summary

In a previous PR the `ruleFormV2` feature flag was renamed when it
should have been deprecated. This PR fixes that.

(cherry picked from commit 7988ced)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 17, 2024
@adcoelho
[ResponseOps][Rules]Deprecate ruleFormV2 flag. (elastic#196507)
52e0870 
Fixes elastic#196493

## Summary

In a previous PR the `ruleFormV2` feature flag was renamed when it
should have been deprecated. This PR fixes that.

(cherry picked from commit 7988ced)
kibanamachine added a commit that referenced this issue Oct 17, 2024
@kibanamachine @adcoelho
[8.x] [ResponseOps][Rules]Deprecate `ruleFormV2` flag. (#19…
fc32304 
…6507) (#196703)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Rules]Deprecate `ruleFormV2` flag.
(#196507)](#196507)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T13:48:36Z","message":"[ResponseOps][Rules]Deprecate
`ruleFormV2` flag. (#196507)\n\nFixes #196493\r\n\r\n##
Summary\r\n\r\nIn a previous PR the `ruleFormV2` feature flag was
renamed when it\r\nshould have been deprecated. This PR fixes
that.","sha":"7988ced8ea04966a02901e68791eb6f24d6ea40e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","v9.0.0","Feature:Alerting/RulesFramework","backport:prev-minor","v8.16.0"],"title":"[ResponseOps][Rules]Deprecate
`ruleFormV2`
flag.","number":196507,"url":"https://github.com/elastic/kibana/pull/196507","mergeCommit":{"message":"[ResponseOps][Rules]Deprecate
`ruleFormV2` flag. (#196507)\n\nFixes #196493\r\n\r\n##
Summary\r\n\r\nIn a previous PR the `ruleFormV2` feature flag was
renamed when it\r\nshould have been deprecated. This PR fixes
that.","sha":"7988ced8ea04966a02901e68791eb6f24d6ea40e"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196507","number":196507,"mergeCommit":{"message":"[ResponseOps][Rules]Deprecate
`ruleFormV2` flag. (#196507)\n\nFixes #196493\r\n\r\n##
Summary\r\n\r\nIn a previous PR the `ruleFormV2` feature flag was
renamed when it\r\nshould have been deprecated. This PR fixes
that.","sha":"7988ced8ea04966a02901e68791eb6f24d6ea40e"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Antonio <[email protected]>
kibanamachine added a commit that referenced this issue Oct 21, 2024
@kibanamachine @adcoelho
[8.16] [ResponseOps][Rules]Deprecate &#x60;ruleFormV2&#x60; flag. (#1…
1f26be2 
…96507) (#196702)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[ResponseOps][Rules]Deprecate &#x60;ruleFormV2&#x60; flag.
(#196507)](#196507)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-17T13:48:36Z","message":"[ResponseOps][Rules]Deprecate
`ruleFormV2` flag. (#196507)\n\nFixes #196493\r\n\r\n##
Summary\r\n\r\nIn a previous PR the `ruleFormV2` feature flag was
renamed when it\r\nshould have been deprecated. This PR fixes
that.","sha":"7988ced8ea04966a02901e68791eb6f24d6ea40e","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:ResponseOps","v9.0.0","Feature:Alerting/RulesFramework","backport:prev-minor","v8.16.0"],"title":"[ResponseOps][Rules]Deprecate
`ruleFormV2`
flag.","number":196507,"url":"https://github.com/elastic/kibana/pull/196507","mergeCommit":{"message":"[ResponseOps][Rules]Deprecate
`ruleFormV2` flag. (#196507)\n\nFixes #196493\r\n\r\n##
Summary\r\n\r\nIn a previous PR the `ruleFormV2` feature flag was
renamed when it\r\nshould have been deprecated. This PR fixes
that.","sha":"7988ced8ea04966a02901e68791eb6f24d6ea40e"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196507","number":196507,"mergeCommit":{"message":"[ResponseOps][Rules]Deprecate
`ruleFormV2` flag. (#196507)\n\nFixes #196493\r\n\r\n##
Summary\r\n\r\nIn a previous PR the `ruleFormV2` feature flag was
renamed when it\r\nshould have been deprecated. This PR fixes
that.","sha":"7988ced8ea04966a02901e68791eb6f24d6ea40e"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Antonio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcoelho adcoelho

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ResponseOps][Rules]Deprecate ruleFormV2 flag. adcoelho/kibana
2 participants
@adcoelho @elasticmachine