Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Show alerts from other producers #196053

Closed
kpatticha opened this issue Oct 14, 2024 · 4 comments
Closed

[APM] Show alerts from other producers #196053

kpatticha opened this issue Oct 14, 2024 · 4 comments
Labels
apm:alerting apm enhancement New value added to drive a business result needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@kpatticha
Copy link
Contributor

Currently APM shows only alerts from the apm producer.

const apmAlertsIndices = await alertsClient.getAuthorizedAlertsIndices(['apm']);

We want to show alerts triggered from SLOs

AC

  • TBD
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 14, 2024
@kpatticha kpatticha added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team and removed needs-team Issues missing a team label labels Oct 14, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@kpatticha kpatticha added the needs-refinement A reason and acceptance criteria need to be defined for this issue label Oct 16, 2024
@kpatticha kpatticha changed the title [APM] Show alerts from SLOs [APM] Show alerts from other producers Oct 16, 2024
@smith smith added enhancement New value added to drive a business result apm:alerting apm labels Oct 17, 2024
@iblancof
Copy link
Contributor

Hi @kpatticha,

I think this issue can be closed as this is how that part of the code looks now:

const apmAlertsIndices = await alertsClient.getAuthorizedAlertsIndices(
APM_ALERTING_RULE_TYPE_IDS
);

And APM_ALERTING_RULE_TYPE_IDS contains OBSERVABILITY_RULE_TYPE_IDS that includes the SLO_RULE_TYPE_IDS:

export const APM_ALERTING_RULE_TYPE_IDS: string[] = [...OBSERVABILITY_RULE_TYPE_IDS];

export const OBSERVABILITY_RULE_TYPE_IDS = [
...APM_RULE_TYPE_IDS,
...SYNTHETICS_RULE_TYPE_IDS,
...INFRA_RULE_TYPE_IDS,
...UPTIME_RULE_TYPE_IDS,
...LOG_RULE_TYPE_IDS,
...SLO_RULE_TYPE_IDS,
OBSERVABILITY_THRESHOLD_RULE_TYPE_ID,
];

@kpatticha
Copy link
Contributor Author

Can you please verify if we use the same rule types also in the alerts table (in alerts tabs). I believe we do, if that's the case feel free to close the ticket. Thanks for checking it

@iblancof
Copy link
Contributor

Yes, we use the same rule type IDs there.

You can see the SLO index (alerts-observability.slo.alerts-default) being queried here:

Image

I'm closing the issue, thanks for the feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:alerting apm enhancement New value added to drive a business result needs-refinement A reason and acceptance criteria need to be defined for this issue Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

No branches or pull requests

4 participants