Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Search Sessions Integration.x-pack/test/search_sessions_integration/tests/apps/discover/async_search·ts - Discover discover async search relative timerange works #195955

Open
kibanamachine opened this issue Oct 11, 2024 · 13 comments · Fixed by #197740 · May be fixed by #204827
Open

Failing test: X-Pack Search Sessions Integration.x-pack/test/search_sessions_integration/tests/apps/discover/async_search·ts - Discover discover async search relative timerange works #195955

kibanamachine opened this issue Oct 11, 2024 · 13 comments · Fixed by #197740 · May be fixed by #204827
Assignees
@lukasolson
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort skipped-test Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v9.0.0

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 11, 2024 •
edited
Loading

A test failed on a tracked branch

Error: expected 1 to equal 2
    at Assertion.assert (expect.js:100:11)
    at Assertion.apply (expect.js:227:8)
    at Assertion.be (expect.js:69:22)
    at Context.<anonymous> (async_search.ts:138:45)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at Object.apply (wrap_function.js:74:16)

First failure: kibana-on-merge - main
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 11, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 11, 2024
@kibanamachine kibanamachine added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Oct 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 11, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kertal kertal added loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Oct 15, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

mistic added a commit that referenced this issue Oct 17, 2024
@mistic
skip flaky suite (#195955)
5a474b3
@mistic
Copy link
Member

mistic commented Oct 17, 2024

Skipped.

main: 5a474b3

@davismcphee davismcphee added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Oct 17, 2024
@kertal
Copy link
Member

kertal commented Oct 22, 2024

Screen: Image

@kertal
Copy link
Member

kertal commented Oct 22, 2024

A local run passes, but contains error messages: https://github.com/user-attachments/assets/bd87320d-8893-460a-817d-9f5a4a4220eb

@kertal
Copy link
Member

kertal commented Oct 22, 2024

So this is the test that causes the error, @lukasolson , do you have any idea, why the number of search session could change beween L127 and L139?

kibana/x-pack/test/search_sessions_integration/tests/apps/discover/async_search.ts

Lines 127 to 139 in 5a474b3

const searchesCountBeforeRestore = searchSessionListBeforeRestore[0].searchesCount;
// navigate to Discover
await searchSessionListBeforeRestore[0].view();
await header.waitUntilLoadingHasFinished();
await searchSessions.expectState('restored');
expect(await discover.hasNoResults()).to.be(true);
expect(await toasts.getCount()).to.be(0); // no session restoration related warnings
await searchSessionsManagement.goTo();
const searchSessionListAfterRestore = await searchSessionsManagement.getList();
const searchesCountAfterRestore = searchSessionListAfterRestore[0].searchesCount;
expect(searchesCountBeforeRestore).to.be(searchesCountAfterRestore); // no new searches started during restore

@lukasolson lukasolson mentioned this issue Oct 24, 2024
Merged
@lukasolson lukasolson self-assigned this Oct 24, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 5, 2024
@lukasolson
Fix discover async search relative timerange test (elastic#197740)
380aa33 
## Summary

Resolves elastic#195955.

(cherry picked from commit 4869b8f)
mgadewoll pushed a commit to mgadewoll/kibana that referenced this issue Nov 7, 2024
@lukasolson @mgadewoll
Fix discover async search relative timerange test (elastic#197740)
b8a6d22 
## Summary

Resolves elastic#195955.
@kibanamachine kibanamachine reopened this Nov 7, 2024
@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

@kibanamachine
Copy link
Contributor Author

New failure: kibana-on-merge - main

mistic added a commit that referenced this issue Nov 19, 2024
@mistic
skip flaky suite (#195955)
4726e70
@mistic
Copy link
Member

mistic commented Nov 19, 2024

Skipped.

main: 4726e70

paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@mistic @paulinashakirova
skip flaky suite (elastic#195955)
a88a6d7
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@mistic @CAWilson94
skip flaky suite (elastic#195955)
750df7f
@lukasolson lukasolson linked a pull request Jan 10, 2025 that will close this issue
Draft
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukasolson lukasolson

Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort skipped-test Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v9.0.0
Projects
None yet
Milestone
No milestone
6 participants
@kertal @lukasolson @mistic @elasticmachine @davismcphee @kibanamachine