Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stateful: Home page] Missing information of Store this API key section first time #195382

Closed
L1nBra opened this issue Oct 8, 2024 · 2 comments · Fixed by #198253
Closed

[Stateful: Home page] Missing information of Store this API key section first time #195382

L1nBra opened this issue Oct 8, 2024 · 2 comments · Fixed by #198253
Assignees
Labels
defect-level-2 Serious UX disruption with workaround impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Accessibility Team:Search WCAG A WCAG AA

Comments

@L1nBra
Copy link

L1nBra commented Oct 8, 2024

Description
All information which is accessible for the user should be announced when the user navigates to the element first time (not only when he reaches it second, third and so on time).

Preconditions
Stateful Home page (Overview) is opened.
Use Screen Reader (NVDA).

Steps to reproduce

1.Navigate to New button while using only keyboard by pressing Tab key.
2.Press Enter.
3.Navigate to Name field.
4.Enter any text (f.e.: Test) in Name field.
5.Navigate to Create API Key button while pressing Tab key.
6.Press Enter.
7.Press Tab key.

Create an API key dialog screenshot after creating API key
Image

NVDA Speech Viewer
first time after creating API key and navigating to Copy button
Image

NVDA Speech Viewer
when navigating to other elements inside Create API key dialog and then navigating from the top in the dialog to Copy button again
Image

Actual Result

  • After Creating an API key, Focus goes to New button. Then, after pressing Tab key, focus goes to Copy button and Dialog information is announced, following Copy button announcement. Information about just created API key (Store this API key section), which appeared in the Dialog is not announced at all.

Expected Result

  • Store this API key section information should be announced for the user first time as well.

Notes:
Now user hears information about Store this API key section only if he continues navigating inside Dialog and when again he reaches Dialog and press Tab key. Important: the section is announced as graphic and no focus is visible on the section itself, the focus is visible only on Copy button in this section.

Meta Issue

Kibana Version: 8.16.0-SNAPSHOT

OS: Windows 11 Pro

Browser: Chrome Version 129.0.6668.70 (Official Build) (64-bit)

Screen reader: NVDA

WCAG or Vendor Guidance (optional)

Related to: https://github.com/elastic/search-team/issues/8256

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 8, 2024
@L1nBra L1nBra added WCAG A WCAG AA defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. defect-level-2 Serious UX disruption with workaround and removed impact:critical This issue should be addressed immediately due to a critical level of impact on the product. defect-level-1 Critical UX disruption labels Oct 8, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 10, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 10, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 10, 2024
@L1nBra L1nBra added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Oct 17, 2024
@daveyholler
Copy link
Contributor

@joemcelroy or @TattdCodeMonkey Can you help me verify whether this is a "Search" issue or if there's something that needs to be addressed at a lower level (shared component)?

cc: @radhapolisetty (I've added this to the Search Experiences team project)

@alexwizp alexwizp self-assigned this Oct 29, 2024
alexwizp added a commit to alexwizp/kibana that referenced this issue Oct 29, 2024
alexwizp added a commit to alexwizp/kibana that referenced this issue Oct 30, 2024
alexwizp added a commit that referenced this issue Nov 5, 2024
…section first time (#198253)

Closes: #195382
Closes: #195366

## Description

All information which is accessible for the user should be announced
when the user navigates to the element first time (not only when he
reaches it second, third and so on time).

## What was changed?:

1. added `role="alert"` to correctly pronounce status update. Addind
role attribute also fixes #195366


## Screen:


https://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 5, 2024
…section first time (elastic#198253)

Closes: elastic#195382
Closes: elastic#195366

## Description

All information which is accessible for the user should be announced
when the user navigates to the element first time (not only when he
reaches it second, third and so on time).

## What was changed?:

1. added `role="alert"` to correctly pronounce status update. Addind
role attribute also fixes elastic#195366

## Screen:

https://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81
(cherry picked from commit 92ae754)
kibanamachine added a commit that referenced this issue Nov 5, 2024
…I key section first time (#198253) (#199010)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Stateful: Home page] Missing information of Store this API key
section first time
(#198253)](#198253)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-05T15:38:26Z","message":"fix:
[Stateful: Home page] Missing information of Store this API key section
first time (#198253)\n\nCloses: #195382\r\nCloses: #195366\r\n\r\n##
Description\r\n\r\nAll information which is accessible for the user
should be announced\r\nwhen the user navigates to the element first time
(not only when he\r\nreaches it second, third and so on time).\r\n\r\n##
What was changed?:\r\n\r\n1. added `role=\"alert\"` to correctly
pronounce status update. Addind\r\nrole attribute also fixes
#195366\r\n\r\n\r\n##
Screen:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81","sha":"92ae754ff93b52b742885761afa8b2b7d857ce25","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"fix:
[Stateful: Home page] Missing information of Store this API key section
first
time","number":198253,"url":"https://github.com/elastic/kibana/pull/198253","mergeCommit":{"message":"fix:
[Stateful: Home page] Missing information of Store this API key section
first time (#198253)\n\nCloses: #195382\r\nCloses: #195366\r\n\r\n##
Description\r\n\r\nAll information which is accessible for the user
should be announced\r\nwhen the user navigates to the element first time
(not only when he\r\nreaches it second, third and so on time).\r\n\r\n##
What was changed?:\r\n\r\n1. added `role=\"alert\"` to correctly
pronounce status update. Addind\r\nrole attribute also fixes
#195366\r\n\r\n\r\n##
Screen:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81","sha":"92ae754ff93b52b742885761afa8b2b7d857ce25"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198253","number":198253,"mergeCommit":{"message":"fix:
[Stateful: Home page] Missing information of Store this API key section
first time (#198253)\n\nCloses: #195382\r\nCloses: #195366\r\n\r\n##
Description\r\n\r\nAll information which is accessible for the user
should be announced\r\nwhen the user navigates to the element first time
(not only when he\r\nreaches it second, third and so on time).\r\n\r\n##
What was changed?:\r\n\r\n1. added `role=\"alert\"` to correctly
pronounce status update. Addind\r\nrole attribute also fixes
#195366\r\n\r\n\r\n##
Screen:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81","sha":"92ae754ff93b52b742885761afa8b2b7d857ce25"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
mgadewoll pushed a commit to mgadewoll/kibana that referenced this issue Nov 7, 2024
…section first time (elastic#198253)

Closes: elastic#195382
Closes: elastic#195366

## Description

All information which is accessible for the user should be announced
when the user navigates to the element first time (not only when he
reaches it second, third and so on time).

## What was changed?:

1. added `role="alert"` to correctly pronounce status update. Addind
role attribute also fixes elastic#195366


## Screen:


https://github.com/user-attachments/assets/3f7707e4-5cc4-451b-9e5c-372e2e7dab81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect-level-2 Serious UX disruption with workaround impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Project:Accessibility Team:Search WCAG A WCAG AA
Projects
None yet
4 participants